From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michael Dege <michael.dege@renesas.com>,
Christian Mardmoeller <christian.mardmoeller@renesas.com>,
Dennis Ostermann <dennis.ostermann@renesas.com>
Subject: Re: [PATCH net-next 2/2] net: renesas: rswitch: request ts interrupt at port open
Date: Fri, 20 Dec 2024 13:51:44 +0500 [thread overview]
Message-ID: <b32d3aa4-33ba-4b9b-b7d3-181c451f8528@cogentembedded.com> (raw)
In-Reply-To: <Z2UtCBwofyoHlZi0@mev-dev.igk.intel.com>
> Wasn't previous implementation more obvious? This ts irq you have one
> per device, no per port, so it better fit to one time initialization
> instead of checking if it is first and last port.
>
> Anyway, it is your descision, patch looks correct:
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
For data interrupts, after making them per-port, it is better to request only for opened device, to
avoid unneeded calls to shared handlers when some ports are up and some are not.
And once data interrupts are requested at open, it looks cleaner for me to request ts interrupt at open
as well. Although I agree that this is matter of taste.
Nikita
prev parent reply other threads:[~2024-12-20 8:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 4:16 [PATCH net-next 0/2] net: renesas: rswitch: update irq handling Nikita Yushchenko
2024-12-20 4:16 ` [PATCH net-next 1/2] net: renesas: rswitch: use per-port irq handlers Nikita Yushchenko
2024-12-20 7:59 ` Geert Uytterhoeven
2024-12-20 8:09 ` Nikita Yushchenko
2024-12-20 9:11 ` Yoshihiro Shimoda
2024-12-20 9:23 ` Nikita Yushchenko
2024-12-20 9:31 ` Andrew Lunn
2024-12-20 8:25 ` Michal Swiatkowski
2024-12-20 9:11 ` Nikita Yushchenko
2024-12-23 5:19 ` Michal Swiatkowski
2024-12-30 10:58 ` Michal Swiatkowski
2024-12-20 9:19 ` Andrew Lunn
2024-12-20 9:33 ` Nikita Yushchenko
2024-12-20 12:16 ` Andrew Lunn
2024-12-20 12:46 ` Nikita Yushchenko
2024-12-20 4:16 ` [PATCH net-next 2/2] net: renesas: rswitch: request ts interrupt at port open Nikita Yushchenko
2024-12-20 8:38 ` Michal Swiatkowski
2024-12-20 8:51 ` Nikita Yushchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b32d3aa4-33ba-4b9b-b7d3-181c451f8528@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew+netdev@lunn.ch \
--cc=christian.mardmoeller@renesas.com \
--cc=davem@davemloft.net \
--cc=dennis.ostermann@renesas.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®