From: Sarthak Garg <quic_sartgarg@quicinc.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<quic_cang@quicinc.com>, <quic_nguyenb@quicinc.com>,
<quic_rampraka@quicinc.com>, <quic_pragalla@quicinc.com>,
<quic_sayalil@quicinc.com>, <quic_nitirawa@quicinc.com>,
<quic_bhaskarv@quicinc.com>
Subject: Re: [PATCH V2 0/3] Add level shifter support for qualcomm SOC's
Date: Mon, 16 Jun 2025 12:44:00 +0530 [thread overview]
Message-ID: <b35d6797-c574-4b85-878d-502fb4b22152@quicinc.com> (raw)
In-Reply-To: <CAPDyKFoKh6KLtn6-Rvttt9zKh2fk7T28t_jC7KC8peYE+RkL5Q@mail.gmail.com>
On 5/27/2025 8:05 PM, Ulf Hansson wrote:
> On Fri, 23 May 2025 at 20:25, Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 5/23/25 12:57 PM, Sarthak Garg wrote:
>>> Add level shifter support for qualcomm SOC's.
>>>
>>> - Changed from v1
>>> - As suggested by Krzysztof Kozlowski redesigned logic to use
>>> compatible property for adding this level shifter support.
>>> - Addressed Adrian Hunter comments on V1 with resepect to
>>> checkpatch.
>>> - Cleared the bits first and then set bits in
>>> sdhci_msm_execute_tuning as suggested by Adrian Hunter.
>>> - Upated the if condition logic in msm_set_clock_rate_for_bus_mode
>>> as suggested by Adrian Hunter.
>>
>> During internal review I suggested we could introduce a generic quirk,
>> perhaps called "max-hs-frequency" which would update this
>> currently-constant value:
>>
>> ---------------- drivers/mmc/core/sd.c ----------------
>> if (status[13] & SD_MODE_HIGH_SPEED)
>> card->sw_caps.hs_max_dtr = HIGH_SPEED_MAX_DTR;
>> -------------------------------------------------------
>>
>> (50 MHz)
>>
>> which I believe is where it comes from
>
> I agree that a DT property for the mmc controller would make sense.
>
> Although, this seems limited to SD UHS-I speed modes, so perhaps
> "max-sd-uhs-frequency" would be a better name for it?
>
> Kind regards
> Uffe
Sure will update this logic in V3.
next prev parent reply other threads:[~2025-06-16 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 10:57 Sarthak Garg
2025-05-23 10:57 ` [PATCH V2 1/3] mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card Sarthak Garg
2025-05-28 11:32 ` Adrian Hunter
2025-05-23 10:57 ` [PATCH V2 2/3] mmc: sdhci-msm: Limit HS mode frequency to 37.5MHz Sarthak Garg
2025-05-23 10:57 ` [PATCH V2 3/3] arm64: dts: qcom: sm8550: Remove SDR104/SDR50 broken caps Sarthak Garg
2025-05-23 18:25 ` [PATCH V2 0/3] Add level shifter support for qualcomm SOC's Konrad Dybcio
2025-05-27 14:35 ` Ulf Hansson
2025-06-16 7:14 ` Sarthak Garg [this message]
2025-06-16 7:13 ` Sarthak Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35d6797-c574-4b85-878d-502fb4b22152@quicinc.com \
--to=quic_sartgarg@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®