Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

[liu weni]

Signed-off-by: Liuweni <qingshenlwy@gmail.com>


In the origin, the code notes are not fit for set_irq_msi.
I modify the code notes, and no any changes for the code.
Is it OK?? thanks!



diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c166019..da2f254 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);

 /**
- * set_irq_data - set irq type data for an irq
+ * set_irq_msi - set MSI descriptor data for an irq
  * @irq: Interrupt number
  * @entry: Pointer to MSI descriptor data
  *
- * Set the hardware irq controller data for an irq
+ * Set the MSI descriptor entry for an irq
  */
 int set_irq_msi(unsigned int irq, struct msi_desc *entry)
 {





Best Regards

Liuweni

[PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

[liu weni]

In the origin, the code notes are not fit for set_irq_msi.
I modify the code notes, and no any changes for the code.


diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c166019..da2f254 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);

 /**
- * set_irq_data - set irq type data for an irq
+ * set_irq_msi - set MSI descriptor data for an irq
  * @irq: Interrupt number
  * @entry: Pointer to MSI descriptor data
  *
- * Set the hardware irq controller data for an irq
+ * Set the MSI descriptor entry for an irq
  */
 int set_irq_msi(unsigned int irq, struct msi_desc *entry)
 {





Best Regards

Liuweni

Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

[Jiri Kosina]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 913 bytes --]

On Mon, 26 Oct 2009, liu weni wrote:

> In the origin, the code notes are not fit for set_irq_msi.
> I modify the code notes, and no any changes for the code.
> 
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..da2f254 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
> 
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */
>  int set_irq_msi(unsigned int irq, struct msi_desc *entry)
>  {

Please send the patch with proper Signed-off-by: line so that I can queue 
it in my tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.