* [PATCH] cpufreq: qcom-nvmem: add sentinel to qcom_cpufreq_ipq806x_match_list
@ 2025-12-05 6:38 xiaopeitux
2025-12-05 9:38 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: xiaopeitux @ 2025-12-05 6:38 UTC (permalink / raw)
To: ansuelsmth, ilia.lin, rafael, linux-arm-msm, linux-pm, linux-kernel
Cc: Pei Xiao
From: Pei Xiao <xiaopei01@kylinos.cn>
The of_device_id table is expected to be NULL-terminated. Without the
sentinel, the traversal of the array can lead to out-of-bound access,
causing undefined behavior.
This adds the missing sentinel to the qcom_cpufreq_ipq806x_match_list
array.
Fixes: 58f5d39d5ed8 ("cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
index 81e16b5a0245..66d3169b2331 100644
--- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
+++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
@@ -263,6 +263,7 @@ static const struct of_device_id qcom_cpufreq_ipq806x_match_list[] __maybe_unuse
{ .compatible = "qcom,ipq8066", .data = (const void *)QCOM_ID_IPQ8066 },
{ .compatible = "qcom,ipq8068", .data = (const void *)QCOM_ID_IPQ8068 },
{ .compatible = "qcom,ipq8069", .data = (const void *)QCOM_ID_IPQ8069 },
+ { /* sentinel */ },
};
static int qcom_cpufreq_ipq8064_name_version(struct device *cpu_dev,
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cpufreq: qcom-nvmem: add sentinel to qcom_cpufreq_ipq806x_match_list
2025-12-05 6:38 [PATCH] cpufreq: qcom-nvmem: add sentinel to qcom_cpufreq_ipq806x_match_list xiaopeitux
@ 2025-12-05 9:38 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2025-12-05 9:38 UTC (permalink / raw)
To: xiaopeitux, ansuelsmth, ilia.lin, rafael, linux-arm-msm,
linux-pm, linux-kernel
Cc: Pei Xiao
On 12/5/25 7:38 AM, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> The of_device_id table is expected to be NULL-terminated. Without the
> sentinel, the traversal of the array can lead to out-of-bound access,
> causing undefined behavior.
>
> This adds the missing sentinel to the qcom_cpufreq_ipq806x_match_list
> array.
>
> Fixes: 58f5d39d5ed8 ("cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM")
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
ouch, thanks for catching that!
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-05 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-05 6:38 [PATCH] cpufreq: qcom-nvmem: add sentinel to qcom_cpufreq_ipq806x_match_list xiaopeitux
2025-12-05 9:38 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®