From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Frank Wunderlich <linux@fw-web.de>,
linux-mediatek@lists.infradead.org,
Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support
Date: Tue, 20 Apr 2021 17:18:32 +0200 [thread overview]
Message-ID: <b38c3539-c864-67b3-95e8-9b652cf6fcbf@linaro.org> (raw)
In-Reply-To: <trinity-4a3f024e-c01d-44e4-a884-530135853d33-1618930770250@3c-app-gmx-bs72>
Hi Frank,
On 20/04/2021 16:59, Frank Wunderlich wrote:
> Hi,
>
>> Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr
>> Von: "Daniel Lezcano" <daniel.lezcano@linaro.org>
>
>> No #ifdef in C file.
> ...
>
>> devm_thermal_add_hwmon_sysfs() ?
>
> based on your comments this should be enough/right?
>
> #if IS_ENABLED(CONFIG_THERMAL_HWMON)
> tzdev->tzp->no_hwmon = false;> ret = devm_thermal_add_hwmon_sysfs(tzdev);
> if (ret)
> dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> #endif
>
> if yes i send out v2, at least it works on my device
just the following lines should work:
ret = devm_thermal_add_hwmon_sysfs(tzdev);
if (ret)
dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
The no_hwmon usage is a bit fuzzy in the thermal core code.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-04-20 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 8:06 Frank Wunderlich
2021-04-18 12:03 ` Aw: " Frank Wunderlich
2021-04-20 12:07 ` Daniel Lezcano
2021-04-20 14:59 ` Aw: " Frank Wunderlich
2021-04-20 15:18 ` Daniel Lezcano [this message]
2021-04-20 15:24 ` Frank Wunderlich
2021-04-20 15:27 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38c3539-c864-67b3-95e8-9b652cf6fcbf@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=frank-w@public-files.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®