* [PATCH] drm/bridge/sii8620: fix link error
@ 2018-04-23 8:47 ` Tobias Regnery
2018-04-23 9:22 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Regnery @ 2018-04-23 8:47 UTC (permalink / raw)
To: architt, a.hajda, dri-devel, linux-kernel; +Cc: m.purski, Tobias Regnery
With CONFIG_EXTCON=m and CONFIG_DRM_SIL_SII8620=y we see the following link
error:
drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_remove':
sil-sii8620.c:(.text+0xd5): undefined reference to `extcon_unregister_notifier'
drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_probe':
sil-sii8620.c:(.text+0x2a4b): undefined reference to `extcon_find_edev_by_node'
sil-sii8620.c:(.text+0x2af4): undefined reference to `extcon_register_notifier'
drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_extcon_work':
sil-sii8620.c:(.text+0x2b94): undefined reference to `extcon_get_state'
Fix this by selecting EXTCON.
Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 3aa65bdecb0e..ab99e36ee034 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -74,6 +74,7 @@ config DRM_SIL_SII8620
tristate "Silicon Image SII8620 HDMI/MHL bridge"
depends on OF && RC_CORE
select DRM_KMS_HELPER
+ select EXTCON
help
Silicon Image SII8620 HDMI/MHL bridge chip driver.
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/bridge/sii8620: fix link error
2018-04-23 8:47 ` [PATCH] drm/bridge/sii8620: fix link error Tobias Regnery
@ 2018-04-23 9:22 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2018-04-23 9:22 UTC (permalink / raw)
To: Tobias Regnery, architt, dri-devel, linux-kernel; +Cc: m.purski
Hi Tobias,
On 23.04.2018 10:47, Tobias Regnery wrote:
> With CONFIG_EXTCON=m and CONFIG_DRM_SIL_SII8620=y we see the following link
> error:
>
> drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_remove':
> sil-sii8620.c:(.text+0xd5): undefined reference to `extcon_unregister_notifier'
> drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_probe':
> sil-sii8620.c:(.text+0x2a4b): undefined reference to `extcon_find_edev_by_node'
> sil-sii8620.c:(.text+0x2af4): undefined reference to `extcon_register_notifier'
> drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_extcon_work':
> sil-sii8620.c:(.text+0x2b94): undefined reference to `extcon_get_state'
>
> Fix this by selecting EXTCON.
>
> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
There is already pending patch[1].
[1]: https://patchwork.kernel.org/patch/10330653/
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 3aa65bdecb0e..ab99e36ee034 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -74,6 +74,7 @@ config DRM_SIL_SII8620
> tristate "Silicon Image SII8620 HDMI/MHL bridge"
> depends on OF && RC_CORE
> select DRM_KMS_HELPER
> + select EXTCON
> help
> Silicon Image SII8620 HDMI/MHL bridge chip driver.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-23 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180423085639epcas3p13d9c120cba4c41bf3f0f18be25f83590@epcas3p1.samsung.com>
2018-04-23 8:47 ` [PATCH] drm/bridge/sii8620: fix link error Tobias Regnery
2018-04-23 9:22 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®