From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
"André Apitzsch" <git@apitzsch.eu>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support
Date: Tue, 27 May 2025 09:19:29 +0100 [thread overview]
Message-ID: <b3d4b080-5a9e-4af0-bce7-41c06d1d27f0@linaro.org> (raw)
In-Reply-To: <10c45ae1d2453f7c81dadeb132b6c2911ab7d95c.camel@mailoo.org>
On 26/05/2025 17:20, Vincent Knecht wrote:
>> You have both
>>
>> if (vfe->res->has_vbif) {
>>
>> and the above switch, there's no point in checking this twice in two
>> different ways.
>>
>> Choose one, suggest has_vbif is enough.
> I think the switch is still needed, so that distinct settings
> can be applied for different SoCs.
>
> Or should I just apply the 8939 settings unconditionally, and keep it
> as an exercice for the next dev who need other settings for another SoC
> to deal with ? 🙂
>
> Thanks
The flag should be enough.
---
bod
next prev parent reply other threads:[~2025-05-27 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 19:25 [PATCH v2 0/4] CAMSS support for MSM8939 Vincent Knecht via B4 Relay
2025-05-25 19:25 ` [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support Vincent Knecht via B4 Relay
2025-05-26 8:08 ` Bryan O'Donoghue
[not found] ` <10c45ae1d2453f7c81dadeb132b6c2911ab7d95c.camel@mailoo.org>
2025-05-27 8:19 ` Bryan O'Donoghue [this message]
2025-05-26 8:13 ` Bryan O'Donoghue
2025-05-26 16:23 ` Vincent Knecht
2025-05-27 12:01 ` Bryan O'Donoghue
2025-05-25 19:25 ` [PATCH v2 2/4] media: qcom: camss: Add support for MSM8939 Vincent Knecht via B4 Relay
2025-05-26 8:20 ` Bryan O'Donoghue
2025-05-26 16:28 ` Vincent Knecht
2025-05-25 19:25 ` [PATCH v2 3/4] media: dt-bindings: Add qcom,msm8939-camss Vincent Knecht via B4 Relay
2025-05-25 19:25 ` [PATCH v2 4/4] arm64: dts: qcom: msm8939: Add camss and cci Vincent Knecht via B4 Relay
2025-05-27 11:57 ` [PATCH v2 0/4] CAMSS support for MSM8939 Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d4b080-5a9e-4af0-bce7-41c06d1d27f0@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®