From: Tim Hockin <thockin@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
ying.huang@intel.com, Aaron Durbin <adurbin@gmail.com>,
priyankag@google.com
Subject: Re: x86/mce merge, integration hickup + crash, design thoughts
Date: Wed, 14 Jan 2009 08:18:29 -0800 [thread overview]
Message-ID: <b3ece790901140818i183bc30n2de01b5edaa6a2c7@mail.gmail.com> (raw)
In-Reply-To: <496DB067.6060402@linux.intel.com>
On Wed, Jan 14, 2009 at 1:29 AM, Andi Kleen <ak@linux.intel.com> wrote:
>
>>
>> I'm 100% on board with that and will even help staff the effort.
>
> Well if you want to change anything the code would be a good idea first to
> establish clearly what is actually broken. I know various areas that need
> improvement (and I have patches fixes most of them), but to my knowledge
> none of them would be fixed by ASCII logging.
>
> Perhaps a good start would be if Ingo could expand what exactly
> he believes is broken currently. At least his earlier "high level" argument
> seems to be large based on clear misunderstandings of what kind
> of MCE events are common and what not. I don't really blame
> him for that since MCEs are obscure and difficult and badly
> documented (I had a hard time getting up to speed on them myself
> and it took me quite some time). But I hope he doesn't
> dismiss the advice from people who have more experience with
> them than him though.
>
> I wrote a long email earlier in the thread with all the reasons why
> ASCII logging is difficult (like the various atomicity issues and also
> others)
> I haven't heard anyone refuting any of the arguments in there, so I assume
> they
> are agreed one by everyone.
>
> I would appreciate if the people who continue to propose ASCII
> logging would explain how they plan to solve these problems.
>
>> This
>> is something that is VERY HIGHLY desired here.
>
> What is exactly desired?
>From my point of view: a single, consistent, easy logging interface
for the kernel to send *structured data* about hardware/system events
and errors up to userspace.
I don't care if it is ASCII, but it probably can be done in ASCII.
That's the cart before the horse, IMHO. I just want something more
structured and better suited than printk().
>> I already have a
>> couple peopel looking at this and other HW-error reporting issues.
>
> I have lots of patches pending for over half a year (including
> tons of bug fixes) and they get all delayed again and again with
> very little justification why. So before writing any new code
> it would be good to just get the already pending improvements in.
We'd LOVE your improvements, if they work. MCE is always a sore point
for us, in that we take too many of them. Anything to reduce their
impact is a win.
Tim
next prev parent reply other threads:[~2009-01-14 16:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 15:50 Ingo Molnar
2008-12-27 22:51 ` Ingo Molnar
2008-12-29 21:41 ` Andi Kleen
2009-01-13 17:45 ` Ingo Molnar
2009-01-13 18:57 ` Tim Hockin
2009-01-14 9:29 ` Andi Kleen
2009-01-14 16:18 ` Tim Hockin [this message]
2009-01-14 18:05 ` Andi Kleen
2009-01-14 19:32 ` Tim Hockin
2009-01-15 22:56 ` Andi Kleen
2009-01-15 23:39 ` Tim Hockin
2009-01-14 2:02 ` Huang Ying
2008-12-30 21:13 ` Russ Anderson
2008-12-31 13:32 ` Andi Kleen
2008-12-31 18:09 ` Russ Anderson
2008-12-29 21:51 ` Andi Kleen
2008-12-30 6:50 ` Ingo Molnar
2008-12-30 9:13 ` Andi Kleen
2008-12-30 21:29 ` Russ Anderson
2009-01-12 22:02 ` Tim Hockin
2009-01-13 5:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3ece790901140818i183bc30n2de01b5edaa6a2c7@mail.gmail.com \
--to=thockin@gmail.com \
--cc=adurbin@gmail.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=priyankag@google.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®