From: Dave Hansen <dave.hansen@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Shuah Khan <shuah@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH] x86/mpx, selftests: Only check bounds-vs-shadow when we keep shadow
Date: Fri, 14 Apr 2017 12:51:46 -0700 [thread overview]
Message-ID: <b3f19f67-109c-ff85-7739-fd21f004c97c@linux.intel.com> (raw)
In-Reply-To: <1491488598-27346-1-git-send-email-joro@8bytes.org>
On 04/06/2017 07:23 AM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The check between the hardware state and our shadow of it is
> checked in the signal handler for all bounds exceptions,
> even for the ones where we don't keep the shadow up2date.
> This is a problem because when no shadow is kept the handler
> fails at this point and hides the real reason of the
> exception.
>
> Move the check into the code-path evaluating normal bounds
> exceptions to prevent this.
Looks good to me.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
prev parent reply other threads:[~2017-04-14 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 14:23 Joerg Roedel
2017-04-12 7:31 ` [tip:x86/mm] " tip-bot for Joerg Roedel
2017-04-14 19:51 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f19f67-109c-ff85-7739-fd21f004c97c@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®