From: "Christian König" <christian.koenig@amd.com>
To: Gabriel C <nix.or.die@gmail.com>
Cc: Jean-Marc Valin <jmvalin@mozilla.com>,
Dave Airlie <airlied@linux.ie>,
alexander.deucher@amd.com,
Felix Kuehling <Felix.Kuehling@amd.com>,
Laura Abbott <labbott@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
michel.daenzer@amd.com, dri-devel@lists.freedesktop.org,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )
Date: Wed, 6 Jun 2018 16:29:10 +0200 [thread overview]
Message-ID: <b3f54efa-9497-3bc6-6390-974079f2cbb3@amd.com> (raw)
In-Reply-To: <CAEJqkgiNVDzboDK1vsn9rYP0G=Q_mGDrkx1VVB8TUkm35Rs9fA@mail.gmail.com>
Am 06.06.2018 um 15:33 schrieb Gabriel C:
> 2018-06-06 14:19 GMT+02:00 Christian König <christian.koenig@amd.com>:
>> Am 06.06.2018 um 14:08 schrieb Gabriel C:
>>> [SNIP]
>>>
>>> That has nothing TODO with the driver nor the original bug you reported. The
>>> problem is that SME is active and that is currently not supported at all
>>> with a that hardware.
> Ok .. so are we playing now kernel an AMD Hardware roulette on each release ?
>
> SME was like this in kernel 4.16.x here and all worked.
>
> Also if you don't support SME at all now on that Hardware while worked before
> please add proper error handling and proper dmesg messages
> letting the user know.
>
> radeon: xxxx : SME not supported on that Hardware anymore , please
> disable SME...
> radeon: xxxx: Update your GPU < or whatever >
>
> How hard would be that ?
Yes, to be precise that isn't the job of the GFX driver to care about
such things.
It is a well known and documented limitation of SME that it is in
general mostly incompatible with GFX (or compute) hardware, and it
actually doesn't matter which hardware or driver you use.
In other words what happens is that as soon as you use GFX (or compute)
SME gets disabled transparently.
The problem is that this happens only on the DMA slow path we just
disabled because of the performance problems.
Going to propose to revert that or at least only use it when SME is
disabled.
Regards,
Christian.
prev parent reply other threads:[~2018-06-06 14:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 13:33 Gabriel C
2018-06-06 14:12 ` Michel Dänzer
2018-06-06 14:44 ` Christian König
2018-06-06 15:03 ` Michel Dänzer
2018-06-06 15:44 ` Gabriel C
2018-06-07 7:07 ` Christian König
2018-06-07 12:32 ` Gabriel C
2018-06-07 16:24 ` Gabriel C
2018-06-07 17:20 ` Christian König
2018-06-08 6:01 ` Christoph Hellwig
2018-06-08 6:47 ` Christian König
2018-06-08 6:02 ` Christoph Hellwig
2018-06-08 6:52 ` Christian König
2018-06-08 13:32 ` Gabriel C
2018-06-11 7:15 ` Christoph Hellwig
2018-06-11 19:23 ` Linus Torvalds
2018-06-06 15:24 ` Gabriel C
2018-06-06 14:29 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f54efa-9497-3bc6-6390-974079f2cbb3@amd.com \
--to=christian.koenig@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jmvalin@mozilla.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.daenzer@amd.com \
--cc=nix.or.die@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®