mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe
Date: Wed, 17 Jun 2020 15:35:58 +0100	[thread overview]
Message-ID: <b41bfead-7b73-be78-c63f-79a0a7e23b2a@arm.com> (raw)
In-Reply-To: <20200617141547.GA30516@kozik-lap>

On 17/06/2020 15:15, Krzysztof Kozlowski wrote:
> On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
>> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
>>
>> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
>>> There is no point to print deferred probe (and its failures to get
>>> resources) as an error.  Also there is no need to print regulator errors
>>> twice.
>>>
>>> In case of multiple probe tries this would pollute the dmesg.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> Reviewed-by: Steven Price <steven.price@arm.com>
>>>
>>> ---
>>>
>>> Changes since v2:
>>> 1. Rebase
>>> 2. Add Steven's review
>>>
>>> Changes since v1:
>>> 1. Remove second error message from calling panfrost_regulator_init()
>>> ---
>>>   drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
> 
> Hi Rob, Tomeu and Steven,
> 
> You're listed as maintainers for panfrost. Is anyone going to pick this
> up?

I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can 
pick it up if Rob/Tomeu are happy for me to do that.

> Maybe I sent it to wrong mailing list or forgot about anything?

No, there's actually a few Panfrost commits waiting, it was on my todo 
list to ask if Rob/Tomeu needed some help with merging patches.

Steve

  reply	other threads:[~2020-06-17 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 20:05 Krzysztof Kozlowski
2020-05-27 20:43 ` Alyssa Rosenzweig
2020-06-17 14:15   ` Krzysztof Kozlowski
2020-06-17 14:35     ` Steven Price [this message]
2020-06-17 19:57       ` Rob Herring
2020-06-18  9:28         ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b41bfead-7b73-be78-c63f-79a0a7e23b2a@arm.com \
    --to=steven.price@arm.com \
    --cc=airlied@linux.ie \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®