From: Andrew Lunn <andrew@lunn.ch>
To: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Subject: Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support
Date: Wed, 19 Nov 2025 20:44:45 +0100 [thread overview]
Message-ID: <b45636cd-48be-4db7-bf2d-a9eb611c14c6@lunn.ch> (raw)
In-Reply-To: <CANXQDtb5XuLKOOorCMYDUpVz6aFuQgvmQZ4pS6RJGkAgeM8n1A@mail.gmail.com>
> > > + if (link_info->support_auto_speeds || link_info->support_auto_speeds2 ||
> > > + link_info->support_pam4_auto_speeds)
> > > + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> > > + lk_ksettings->link_modes.supported);
> >
> > autoneg is more than speed. In fact, 1000BaseX only works are 1G, no
> > link speed negotiation, but you can negotiate pause. Do any of the
> > link modes you support work like this?
>
> All the speeds we support can be auto-negotiated.
If all the speeds you support can do autoneg, why do you need the if ()
Andrew
next prev parent reply other threads:[~2025-11-19 19:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 19:52 [v2, net-next 00/12] bng_en: enhancements for link, Rx/Tx, LRO/TPA & stats Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 01/12] bng_en: Query PHY and report link status Bhargava Marreddy
2025-11-19 9:45 ` [External] : " ALOK TIWARI
2025-11-24 18:04 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 02/12] bng_en: Extend bnge_set_ring_params() for rx-copybreak Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 03/12] bng_en: Add RX support Bhargava Marreddy
2025-11-19 12:11 ` [External] : " ALOK TIWARI
2025-11-14 19:52 ` [v2, net-next 04/12] bng_en: Handle an HWRM completion request Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 05/12] bng_en: Add TX support Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 06/12] bng_en: Add support to handle AGG events Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 07/12] bng_en: Add TPA related functions Bhargava Marreddy
2025-11-19 12:28 ` [External] : " ALOK TIWARI
2025-11-24 18:06 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 08/12] bng_en: Add support for TPA events Bhargava Marreddy
2025-11-15 14:59 ` kernel test robot
2025-11-14 19:52 ` [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support Bhargava Marreddy
2025-11-15 21:08 ` Andrew Lunn
2025-11-19 6:08 ` Bhargava Chenna Marreddy
2025-11-19 19:44 ` Andrew Lunn [this message]
2025-11-24 11:05 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 10/12] bng_en: Add initial support for ethtool stats display Bhargava Marreddy
2025-11-19 14:07 ` [External] : " ALOK TIWARI
2025-11-25 9:36 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 11/12] bng_en: Create per-PF workqueue and timer for asynchronous events Bhargava Marreddy
2025-11-14 19:53 ` [v2, net-next 12/12] bng_en: Query firmware for statistics and accumulate Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b45636cd-48be-4db7-bf2d-a9eb611c14c6@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®