From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Bhargava Marreddy <bhargava.marreddy@broadcom.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Subject: Re: [External] : [v2, net-next 10/12] bng_en: Add initial support for ethtool stats display
Date: Wed, 19 Nov 2025 19:37:43 +0530 [thread overview]
Message-ID: <dff2924b-745e-45eb-bff6-f0c6798a61cf@oracle.com> (raw)
In-Reply-To: <20251114195312.22863-11-bhargava.marreddy@broadcom.com>
> +static const struct {
> + long base_off;
> + char string[ETH_GSTRING_LEN];
> +} bnge_tx_pkts_pri_arr[] = {
> + BNGE_TX_STATS_PRI_ENTRIES(tx_packets),
> +};
> +
> +static const struct {
> + long offset;
> + char string[ETH_GSTRING_LEN];
> +} bnge_port_stats_arr[] = {
> + BNGE_RX_STATS_ENTRY(rx_64b_frames),
> + BNGE_RX_STATS_ENTRY(rx_65b_127b_frames),
> + BNGE_RX_STATS_ENTRY(rx_128b_255b_frames),
> + BNGE_RX_STATS_ENTRY(rx_256b_511b_frames),
> + BNGE_RX_STATS_ENTRY(rx_512b_1023b_frames),
> + BNGE_RX_STATS_ENTRY(rx_1024b_1518b_frames),
> + BNGE_RX_STATS_ENTRY(rx_good_vlan_frames),
> + BNGE_RX_STATS_ENTRY(rx_1519b_2047b_frames),
> + BNGE_RX_STATS_ENTRY(rx_2048b_4095b_frames),
> + BNGE_RX_STATS_ENTRY(rx_4096b_9216b_frames),
> + BNGE_RX_STATS_ENTRY(rx_9217b_16383b_frames),
> + BNGE_RX_STATS_ENTRY(rx_total_frames),
> + BNGE_RX_STATS_ENTRY(rx_ucast_frames),
> + BNGE_RX_STATS_ENTRY(rx_mcast_frames),
> + BNGE_RX_STATS_ENTRY(rx_bcast_frames),
> + BNGE_RX_STATS_ENTRY(rx_fcs_err_frames),
> + BNGE_RX_STATS_ENTRY(rx_ctrl_frames),
> + BNGE_RX_STATS_ENTRY(rx_pause_frames),
> + BNGE_RX_STATS_ENTRY(rx_pfc_frames),
> + BNGE_RX_STATS_ENTRY(rx_align_err_frames),
> + BNGE_RX_STATS_ENTRY(rx_ovrsz_frames),
> + BNGE_RX_STATS_ENTRY(rx_jbr_frames),
> + BNGE_RX_STATS_ENTRY(rx_mtu_err_frames),
> + BNGE_RX_STATS_ENTRY(rx_tagged_frames),
> + BNGE_RX_STATS_ENTRY(rx_double_tagged_frames),
> + BNGE_RX_STATS_ENTRY(rx_good_frames),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri0),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri1),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri2),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri3),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri4),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri5),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri6),
> + BNGE_RX_STATS_ENTRY(rx_pfc_ena_frames_pri7),
> + BNGE_RX_STATS_ENTRY(rx_undrsz_frames),
> + BNGE_RX_STATS_ENTRY(rx_eee_lpi_events),
> + BNGE_RX_STATS_ENTRY(rx_eee_lpi_duration),
> + BNGE_RX_STATS_ENTRY(rx_bytes),
> + BNGE_RX_STATS_ENTRY(rx_runt_bytes),
> + BNGE_RX_STATS_ENTRY(rx_runt_frames),
> + BNGE_RX_STATS_ENTRY(rx_stat_discard),
> + BNGE_RX_STATS_ENTRY(rx_stat_err),
> +
> + BNGE_TX_STATS_ENTRY(tx_64b_frames),
> + BNGE_TX_STATS_ENTRY(tx_65b_127b_frames),
> + BNGE_TX_STATS_ENTRY(tx_128b_255b_frames),
> + BNGE_TX_STATS_ENTRY(tx_256b_511b_frames),
> + BNGE_TX_STATS_ENTRY(tx_512b_1023b_frames),
> + BNGE_TX_STATS_ENTRY(tx_1024b_1518b_frames),
> + BNGE_TX_STATS_ENTRY(tx_good_vlan_frames),
> + BNGE_TX_STATS_ENTRY(tx_1519b_2047b_frames),
> + BNGE_TX_STATS_ENTRY(tx_2048b_4095b_frames),
> + BNGE_TX_STATS_ENTRY(tx_4096b_9216b_frames),
> + BNGE_TX_STATS_ENTRY(tx_9217b_16383b_frames),
> + BNGE_TX_STATS_ENTRY(tx_good_frames),
> + BNGE_TX_STATS_ENTRY(tx_total_frames),
> + BNGE_TX_STATS_ENTRY(tx_ucast_frames),
> + BNGE_TX_STATS_ENTRY(tx_mcast_frames),
> + BNGE_TX_STATS_ENTRY(tx_bcast_frames),
> + BNGE_TX_STATS_ENTRY(tx_pause_frames),
> + BNGE_TX_STATS_ENTRY(tx_pfc_frames),
> + BNGE_TX_STATS_ENTRY(tx_jabber_frames),
> + BNGE_TX_STATS_ENTRY(tx_fcs_err_frames),
> + BNGE_TX_STATS_ENTRY(tx_err),
> + BNGE_TX_STATS_ENTRY(tx_fifo_underruns),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri0),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri1),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri2),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri3),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri4),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri5),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri6),
> + BNGE_TX_STATS_ENTRY(tx_pfc_ena_frames_pri7),
> + BNGE_TX_STATS_ENTRY(tx_eee_lpi_events),
> + BNGE_TX_STATS_ENTRY(tx_eee_lpi_duration),
> + BNGE_TX_STATS_ENTRY(tx_total_collisions),
> + BNGE_TX_STATS_ENTRY(tx_bytes),
> + BNGE_TX_STATS_ENTRY(tx_xthol_frames),
> + BNGE_TX_STATS_ENTRY(tx_stat_discard),
> + BNGE_TX_STATS_ENTRY(tx_stat_error),
RX uses rx_stat_err. Consider using consistent err/error
same for rx_jbr_frames and tx_jabber_frames
> +};
> +
> +static const struct {
> + long offset;
> + char string[ETH_GSTRING_LEN];
> +} bnge_port_stats_ext_arr[] = {
> + BNGE_RX_STATS_EXT_ENTRY(link_down_events),
> + BNGE_RX_STATS_EXT_ENTRY(continuous_pause_events),
> + BNGE_RX_STATS_EXT_ENTRY(resume_pause_events),
> + BNGE_RX_STATS_EXT_ENTRY(continuous_roce_pause_events),
> + BNGE_RX_STATS_EXT_ENTRY(resume_roce_pause_events),
> + BNGE_RX_STATS_EXT_COS_ENTRIES,
> + BNGE_RX_STATS_EXT_PFC_ENTRIES,
> + BNGE_RX_STATS_EXT_ENTRY(rx_bits),
> + BNGE_RX_STATS_EXT_ENTRY(rx_buffer_passed_threshold),
> + BNGE_RX_STATS_EXT_ENTRY(rx_pcs_symbol_err),
> + BNGE_RX_STATS_EXT_ENTRY(rx_corrected_bits),
> + BNGE_RX_STATS_EXT_DISCARD_COS_ENTRIES,
> + BNGE_RX_STATS_EXT_ENTRY(rx_fec_corrected_blocks),
> + BNGE_RX_STATS_EXT_ENTRY(rx_fec_uncorrectable_blocks),
> + BNGE_RX_STATS_EXT_ENTRY(rx_filter_miss),
> +};
> +
Thanks,
Alok
next prev parent reply other threads:[~2025-11-19 14:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 19:52 [v2, net-next 00/12] bng_en: enhancements for link, Rx/Tx, LRO/TPA & stats Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 01/12] bng_en: Query PHY and report link status Bhargava Marreddy
2025-11-19 9:45 ` [External] : " ALOK TIWARI
2025-11-24 18:04 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 02/12] bng_en: Extend bnge_set_ring_params() for rx-copybreak Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 03/12] bng_en: Add RX support Bhargava Marreddy
2025-11-19 12:11 ` [External] : " ALOK TIWARI
2025-11-14 19:52 ` [v2, net-next 04/12] bng_en: Handle an HWRM completion request Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 05/12] bng_en: Add TX support Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 06/12] bng_en: Add support to handle AGG events Bhargava Marreddy
2025-11-14 19:52 ` [v2, net-next 07/12] bng_en: Add TPA related functions Bhargava Marreddy
2025-11-19 12:28 ` [External] : " ALOK TIWARI
2025-11-24 18:06 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 08/12] bng_en: Add support for TPA events Bhargava Marreddy
2025-11-15 14:59 ` kernel test robot
2025-11-14 19:52 ` [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support Bhargava Marreddy
2025-11-15 21:08 ` Andrew Lunn
2025-11-19 6:08 ` Bhargava Chenna Marreddy
2025-11-19 19:44 ` Andrew Lunn
2025-11-24 11:05 ` Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 10/12] bng_en: Add initial support for ethtool stats display Bhargava Marreddy
2025-11-19 14:07 ` ALOK TIWARI [this message]
2025-11-25 9:36 ` [External] : " Bhargava Chenna Marreddy
2025-11-14 19:52 ` [v2, net-next 11/12] bng_en: Create per-PF workqueue and timer for asynchronous events Bhargava Marreddy
2025-11-14 19:53 ` [v2, net-next 12/12] bng_en: Query firmware for statistics and accumulate Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dff2924b-745e-45eb-bff6-f0c6798a61cf@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®