From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kas@kernel.org" <kas@kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>
Cc: "andrew+kernel@donnellan.id.au" <andrew+kernel@donnellan.id.au>,
"luto@kernel.org" <luto@kernel.org>,
"pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>,
"rppt@kernel.org" <rppt@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"kernel-team@meta.com" <kernel-team@meta.com>,
"david@kernel.org" <david@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterx@redhat.com" <peterx@redhat.com>,
"tj@kernel.org" <tj@kernel.org>,
"azpijr@gmail.com" <azpijr@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"rmclure@linux.ibm.com" <rmclure@linux.ibm.com>,
"bp@alien8.de" <bp@alien8.de>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/mm: Define the zapped-entry checks only with CONFIG_DEBUG_VM
Date: Tue, 3 Nov 2026 15:50:04 +0000 [thread overview]
Message-ID: <b45fe4c2a730a23845a36b5beba4f434c7be7477.camel@intel.com> (raw)
In-Reply-To: <aumzjHyJsshPJBUI@thinkstation>
On Tue, 2026-11-03 at 10:13 +0000, Kiryl Shutsemau wrote:
> On Mon, Nov 02, 2026 at 01:12:47PM -0800, Dave Hansen wrote:
> > Or, heck, I'm not that attached to these checks. Let's just kill them.
>
> Works for me. x86 is the only architecture with them, although arm64 and
> riscv have shadow stacks too, and the x86 helpers already keep
> Write=0,Dirty=1 out of other VMAs. Patch below, without the Fixes: tag.
>
> Rick, any objection?
Eh, I guess I'm lukewarm on it. These checks only catch the case at zap time, so
it's not a huge protection that is being pulled out. I thought they were useful.
At the same time, they have never triggered.
prev parent reply other threads:[~2026-11-03 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 14:39 Kiryl Shutsemau (Meta)
2026-11-02 16:09 ` Jose A. Perez de Azpillaga
2026-11-02 16:53 ` Edgecombe, Rick P
2026-11-02 17:32 ` Kiryl Shutsemau
2026-11-02 19:07 ` Edgecombe, Rick P
2026-11-02 21:12 ` Dave Hansen
2026-11-03 10:13 ` Kiryl Shutsemau
2026-11-03 15:50 ` Edgecombe, Rick P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b45fe4c2a730a23845a36b5beba4f434c7be7477.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+kernel@donnellan.id.au \
--cc=azpijr@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rmclure@linux.ibm.com \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®