* [PATCH v2] ASoC: codecs: pcm3168a: do not request the reset GPIO as non-exclusive
@ 2026-11-05 8:42 Bartosz Golaszewski
2026-11-05 8:44 ` Cezary Rojewski
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2026-11-05 8:42 UTC (permalink / raw)
To: Cezary Rojewski, Shenghao Ding, Kevin Lu, Baojun Xu, Sen Wang,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Linus Walleij, Bartosz Golaszewski
Cc: linux-sound, linux-kernel, linux-gpio, Bartosz Golaszewski
The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
rely on the GPIO shared proxy. All users of this codec driver are either
ARM64 - this architecture now enables shared GPIOs automatically for
everyone - or x86 and don't share pins.
The driver no longer has to care about the sharing so drop the flag.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v2:
- Tweak commit subject
- Extend commit message to cover the non-arm64 case too
- Link to v1: https://patch.msgid.link/20261103-pcm3168a-non-exclusive-gpios-v1-1-5cfdcf36c915@oss.qualcomm.com
---
sound/soc/codecs/pcm3168a.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
index 6f45ea4869a75d77344b06e1092aeedcea160058..c1a263216ea6d88757053e93d782b8c8c01f8d1e 100644
--- a/sound/soc/codecs/pcm3168a.c
+++ b/sound/soc/codecs/pcm3168a.c
@@ -725,16 +725,11 @@ int pcm3168a_probe(struct device *dev, struct regmap *regmap)
dev_set_drvdata(dev, pcm3168a);
/*
- * Request the reset (connected to RST pin) gpio line as non exclusive
- * as the same reset line might be connected to multiple pcm3168a codec
- *
* The RST is low active, we want the GPIO line to be high initially, so
* request the initial level to LOW which in practice means DEASSERTED:
* The deasserted level of GPIO_ACTIVE_LOW is HIGH.
*/
- pcm3168a->gpio_rst = devm_gpiod_get_optional(dev, "reset",
- GPIOD_OUT_LOW |
- GPIOD_FLAGS_BIT_NONEXCLUSIVE);
+ pcm3168a->gpio_rst = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(pcm3168a->gpio_rst))
return dev_err_probe(dev, PTR_ERR(pcm3168a->gpio_rst),
"failed to acquire RST gpio\n");
---
base-commit: 2637bdec0535a2044cd830eba9a79363651d9043
change-id: 20261103-pcm3168a-non-exclusive-gpios-10918c1070f2
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ASoC: codecs: pcm3168a: do not request the reset GPIO as non-exclusive
2026-11-05 8:42 [PATCH v2] ASoC: codecs: pcm3168a: do not request the reset GPIO as non-exclusive Bartosz Golaszewski
@ 2026-11-05 8:44 ` Cezary Rojewski
0 siblings, 0 replies; 2+ messages in thread
From: Cezary Rojewski @ 2026-11-05 8:44 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linux-sound, linux-kernel, linux-gpio, Shenghao Ding, Kevin Lu,
Baojun Xu, Sen Wang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Linus Walleij, Bartosz Golaszewski
On 11/5/2026 9:42 AM, Bartosz Golaszewski wrote:
> The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
> rely on the GPIO shared proxy. All users of this codec driver are either
> ARM64 - this architecture now enables shared GPIOs automatically for
> everyone - or x86 and don't share pins.
>
> The driver no longer has to care about the sharing so drop the flag.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> Changes in v2:
> - Tweak commit subject
> - Extend commit message to cover the non-arm64 case too
> - Link to v1: https://patch.msgid.link/20261103-pcm3168a-non-exclusive-gpios-v1-1-5cfdcf36c915@oss.qualcomm.com
Thank you for the update, Bartosz. LGTM
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-05 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-05 8:42 [PATCH v2] ASoC: codecs: pcm3168a: do not request the reset GPIO as non-exclusive Bartosz Golaszewski
2026-11-05 8:44 ` Cezary Rojewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®