From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Umang Chheda <quic_uchheda@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kamal Wadhwa <quic_kamalw@quicinc.com>
Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC
Date: Thu, 25 Jan 2024 10:45:12 +0100 [thread overview]
Message-ID: <b4a9ad3e-392f-42ff-8fed-dd86b013176b@linaro.org> (raw)
In-Reply-To: <CAA8EJpr6XrhNp2gdbqmCow7ShXLNXEwGZ-a_Yxr08bcxtORg6A@mail.gmail.com>
On 1/25/24 09:26, Dmitry Baryshkov wrote:
> On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>
>> Hi Dmitry,
>>
>> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
>>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>>>
>>>> qcm6490-idp platform supports PM7250B PMIC as well.
>>>> Add support for the same.
>>>
>>> The platform can not "support" PMIC. Please fix the commit message.
>> Shall I change the commit message as below in the next patch ?
>> "Add PM7250B PMIC support for qcm6490-idp"
>
> This is also not accurate. You are not adding support for the PMIC.
> You are describing PMICs present on the board.
Umang, consider one of:
arm64: dts: qcom: qcm6490-idp:
"Include PM7250B"
"Enable PM7250B"
"Configure PM7250B"
Konrad
next prev parent reply other threads:[~2024-01-25 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 10:28 Umang Chheda
2024-01-23 12:18 ` Dmitry Baryshkov
2024-01-25 8:10 ` Umang Chheda
2024-01-25 8:26 ` Dmitry Baryshkov
2024-01-25 9:45 ` Konrad Dybcio [this message]
2024-01-25 11:56 ` Umang Chheda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4a9ad3e-392f-42ff-8fed-dd86b013176b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kamalw@quicinc.com \
--cc=quic_uchheda@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®