* [PATCH] scsi: qedi: remove unused variable udev & uctrl
@ 2020-05-05 12:19 Xie XiuQi
2020-05-05 15:28 ` Lee Duncan
2020-05-12 3:28 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Xie XiuQi @ 2020-05-05 12:19 UTC (permalink / raw)
To: QLogic-Storage-Upstream, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
uctrl and udev are unused after commit 9632a6b4b747
("scsi: qedi: Move LL2 producer index processing in BH.")
Remove them.
Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
---
drivers/scsi/qedi/qedi_main.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index b995b19865ca..313f7e10aed9 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -658,8 +658,6 @@ static struct qedi_ctx *qedi_host_alloc(struct pci_dev *pdev)
static int qedi_ll2_rx(void *cookie, struct sk_buff *skb, u32 arg1, u32 arg2)
{
struct qedi_ctx *qedi = (struct qedi_ctx *)cookie;
- struct qedi_uio_dev *udev;
- struct qedi_uio_ctrl *uctrl;
struct skb_work_list *work;
struct ethhdr *eh;
@@ -698,9 +696,6 @@ static int qedi_ll2_rx(void *cookie, struct sk_buff *skb, u32 arg1, u32 arg2)
"Allowed frame ethertype [0x%x] len [0x%x].\n",
eh->h_proto, skb->len);
- udev = qedi->udev;
- uctrl = udev->uctrl;
-
work = kzalloc(sizeof(*work), GFP_ATOMIC);
if (!work) {
QEDI_WARN(&qedi->dbg_ctx,
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qedi: remove unused variable udev & uctrl
2020-05-05 12:19 [PATCH] scsi: qedi: remove unused variable udev & uctrl Xie XiuQi
@ 2020-05-05 15:28 ` Lee Duncan
2020-05-12 3:28 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Lee Duncan @ 2020-05-05 15:28 UTC (permalink / raw)
To: Xie XiuQi, QLogic-Storage-Upstream, jejb, martin.petersen
Cc: linux-scsi, linux-kernel
On 5/5/20 5:19 AM, Xie XiuQi wrote:
> uctrl and udev are unused after commit 9632a6b4b747
> ("scsi: qedi: Move LL2 producer index processing in BH.")
>
> Remove them.
>
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
> ---
> drivers/scsi/qedi/qedi_main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index b995b19865ca..313f7e10aed9 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -658,8 +658,6 @@ static struct qedi_ctx *qedi_host_alloc(struct pci_dev *pdev)
> static int qedi_ll2_rx(void *cookie, struct sk_buff *skb, u32 arg1, u32 arg2)
> {
> struct qedi_ctx *qedi = (struct qedi_ctx *)cookie;
> - struct qedi_uio_dev *udev;
> - struct qedi_uio_ctrl *uctrl;
> struct skb_work_list *work;
> struct ethhdr *eh;
>
> @@ -698,9 +696,6 @@ static int qedi_ll2_rx(void *cookie, struct sk_buff *skb, u32 arg1, u32 arg2)
> "Allowed frame ethertype [0x%x] len [0x%x].\n",
> eh->h_proto, skb->len);
>
> - udev = qedi->udev;
> - uctrl = udev->uctrl;
> -
> work = kzalloc(sizeof(*work), GFP_ATOMIC);
> if (!work) {
> QEDI_WARN(&qedi->dbg_ctx,
>
Reviewed-by: Lee Duncan <lduncan@suse.com>
--
Lee
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qedi: remove unused variable udev & uctrl
2020-05-05 12:19 [PATCH] scsi: qedi: remove unused variable udev & uctrl Xie XiuQi
2020-05-05 15:28 ` Lee Duncan
@ 2020-05-12 3:28 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-05-12 3:28 UTC (permalink / raw)
To: QLogic-Storage-Upstream, Xie XiuQi, jejb
Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Tue, 5 May 2020 20:19:04 +0800, Xie XiuQi wrote:
> uctrl and udev are unused after commit 9632a6b4b747
> ("scsi: qedi: Move LL2 producer index processing in BH.")
>
> Remove them.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qedi: Remove unused variable udev & uctrl
https://git.kernel.org/mkp/scsi/c/f9491ed56e3a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-12 3:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 12:19 [PATCH] scsi: qedi: remove unused variable udev & uctrl Xie XiuQi
2020-05-05 15:28 ` Lee Duncan
2020-05-12 3:28 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®