* [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
@ 2024-06-28 21:47 Armin Wolf
2024-06-28 21:57 ` Pali Rohár
2024-06-30 16:13 ` Guenter Roeck
0 siblings, 2 replies; 5+ messages in thread
From: Armin Wolf @ 2024-06-28 21:47 UTC (permalink / raw)
To: pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
The BIOS on this machine is buggy and will in some cases return
an error when trying to get the fan state, but reading of the
RPM values and the temperature sensors still works.
Closes: https://github.com/vitorafsr/i8kutils/issues/38
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
Documentation/hwmon/dell-smm-hwmon.rst | 2 ++
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
2 files changed, 9 insertions(+)
diff --git a/Documentation/hwmon/dell-smm-hwmon.rst b/Documentation/hwmon/dell-smm-hwmon.rst
index 977263cb57a8..74905675d71f 100644
--- a/Documentation/hwmon/dell-smm-hwmon.rst
+++ b/Documentation/hwmon/dell-smm-hwmon.rst
@@ -360,6 +360,8 @@ Firmware Bug Affected Machines
======================================================= =================
Reading of fan states return spurious errors. Precision 490
+ OptiPlex 7060
+
Reading of fan types causes erratic fan behaviour. Studio XPS 8000
Studio XPS 8100
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 48a81c64f00d..c75bfe93f2f6 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
},
},
+ {
+ .ident = "Dell OptiPlex 7060",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"),
+ },
+ },
{
.ident = "Dell Precision",
.matches = {
--
2.39.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
2024-06-28 21:47 [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table Armin Wolf
@ 2024-06-28 21:57 ` Pali Rohár
2024-06-28 22:43 ` Armin Wolf
2024-06-30 16:13 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2024-06-28 21:57 UTC (permalink / raw)
To: Armin Wolf; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
On Friday 28 June 2024 23:47:23 Armin Wolf wrote:
> The BIOS on this machine is buggy and will in some cases return
> an error when trying to get the fan state, but reading of the
> RPM values and the temperature sensors still works.
Does this error affects machine usage (e.g. freeze of CPU or some
erratic fan behavior)? Or just kernel does not receive fan state and is
unable to report meaningful value to userspace?
>
> Closes: https://github.com/vitorafsr/i8kutils/issues/38
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> Documentation/hwmon/dell-smm-hwmon.rst | 2 ++
> drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/hwmon/dell-smm-hwmon.rst b/Documentation/hwmon/dell-smm-hwmon.rst
> index 977263cb57a8..74905675d71f 100644
> --- a/Documentation/hwmon/dell-smm-hwmon.rst
> +++ b/Documentation/hwmon/dell-smm-hwmon.rst
> @@ -360,6 +360,8 @@ Firmware Bug Affected Machines
> ======================================================= =================
> Reading of fan states return spurious errors. Precision 490
>
> + OptiPlex 7060
> +
> Reading of fan types causes erratic fan behaviour. Studio XPS 8000
>
> Studio XPS 8100
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 48a81c64f00d..c75bfe93f2f6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
> DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
> },
> },
> + {
> + .ident = "Dell OptiPlex 7060",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"),
> + },
> + },
> {
> .ident = "Dell Precision",
> .matches = {
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
2024-06-28 21:57 ` Pali Rohár
@ 2024-06-28 22:43 ` Armin Wolf
2024-06-28 22:47 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Armin Wolf @ 2024-06-28 22:43 UTC (permalink / raw)
To: Pali Rohár; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
Am 28.06.24 um 23:57 schrieb Pali Rohár:
> On Friday 28 June 2024 23:47:23 Armin Wolf wrote:
>> The BIOS on this machine is buggy and will in some cases return
>> an error when trying to get the fan state, but reading of the
>> RPM values and the temperature sensors still works.
> Does this error affects machine usage (e.g. freeze of CPU or some
> erratic fan behavior)? Or just kernel does not receive fan state and is
> unable to report meaningful value to userspace?
Basically, it seems that the BIOS will return an error if the to-be-returned fan state is less than 2.
Everything else seems to work.
Thanks,
Armin Wolf
>> Closes: https://github.com/vitorafsr/i8kutils/issues/38
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>> ---
>> Documentation/hwmon/dell-smm-hwmon.rst | 2 ++
>> drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>> 2 files changed, 9 insertions(+)
>>
>> diff --git a/Documentation/hwmon/dell-smm-hwmon.rst b/Documentation/hwmon/dell-smm-hwmon.rst
>> index 977263cb57a8..74905675d71f 100644
>> --- a/Documentation/hwmon/dell-smm-hwmon.rst
>> +++ b/Documentation/hwmon/dell-smm-hwmon.rst
>> @@ -360,6 +360,8 @@ Firmware Bug Affected Machines
>> ======================================================= =================
>> Reading of fan states return spurious errors. Precision 490
>>
>> + OptiPlex 7060
>> +
>> Reading of fan types causes erratic fan behaviour. Studio XPS 8000
>>
>> Studio XPS 8100
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index 48a81c64f00d..c75bfe93f2f6 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
>> DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
>> },
>> },
>> + {
>> + .ident = "Dell OptiPlex 7060",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"),
>> + },
>> + },
>> {
>> .ident = "Dell Precision",
>> .matches = {
>> --
>> 2.39.2
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
2024-06-28 22:43 ` Armin Wolf
@ 2024-06-28 22:47 ` Pali Rohár
0 siblings, 0 replies; 5+ messages in thread
From: Pali Rohár @ 2024-06-28 22:47 UTC (permalink / raw)
To: Armin Wolf; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
On Saturday 29 June 2024 00:43:08 Armin Wolf wrote:
> Am 28.06.24 um 23:57 schrieb Pali Rohár:
>
> > On Friday 28 June 2024 23:47:23 Armin Wolf wrote:
> > > The BIOS on this machine is buggy and will in some cases return
> > > an error when trying to get the fan state, but reading of the
> > > RPM values and the temperature sensors still works.
> > Does this error affects machine usage (e.g. freeze of CPU or some
> > erratic fan behavior)? Or just kernel does not receive fan state and is
> > unable to report meaningful value to userspace?
>
> Basically, it seems that the BIOS will return an error if the to-be-returned fan state is less than 2.
> Everything else seems to work.
Ok, if there is no negative impact then fine for me.
Acked-by: Pali Rohár <pali@kernel.org>
> Thanks,
> Armin Wolf
>
> > > Closes: https://github.com/vitorafsr/i8kutils/issues/38
> > > Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> > > ---
> > > Documentation/hwmon/dell-smm-hwmon.rst | 2 ++
> > > drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > 2 files changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/hwmon/dell-smm-hwmon.rst b/Documentation/hwmon/dell-smm-hwmon.rst
> > > index 977263cb57a8..74905675d71f 100644
> > > --- a/Documentation/hwmon/dell-smm-hwmon.rst
> > > +++ b/Documentation/hwmon/dell-smm-hwmon.rst
> > > @@ -360,6 +360,8 @@ Firmware Bug Affected Machines
> > > ======================================================= =================
> > > Reading of fan states return spurious errors. Precision 490
> > >
> > > + OptiPlex 7060
> > > +
> > > Reading of fan types causes erratic fan behaviour. Studio XPS 8000
> > >
> > > Studio XPS 8100
> > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > index 48a81c64f00d..c75bfe93f2f6 100644
> > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > @@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
> > > DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
> > > },
> > > },
> > > + {
> > > + .ident = "Dell OptiPlex 7060",
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"),
> > > + },
> > > + },
> > > {
> > > .ident = "Dell Precision",
> > > .matches = {
> > > --
> > > 2.39.2
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
2024-06-28 21:47 [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table Armin Wolf
2024-06-28 21:57 ` Pali Rohár
@ 2024-06-30 16:13 ` Guenter Roeck
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2024-06-30 16:13 UTC (permalink / raw)
To: Armin Wolf; +Cc: pali, jdelvare, linux-hwmon, linux-kernel
On Fri, Jun 28, 2024 at 11:47:23PM +0200, Armin Wolf wrote:
> The BIOS on this machine is buggy and will in some cases return
> an error when trying to get the fan state, but reading of the
> RPM values and the temperature sensors still works.
>
> Closes: https://github.com/vitorafsr/i8kutils/issues/38
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> Acked-by: Pali Rohár <pali@kernel.org>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-30 16:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-28 21:47 [PATCH] hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table Armin Wolf
2024-06-28 21:57 ` Pali Rohár
2024-06-28 22:43 ` Armin Wolf
2024-06-28 22:47 ` Pali Rohár
2024-06-30 16:13 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®