From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jthumshirn@suse.de" <jthumshirn@suse.de>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"RaghavaAditya.Renukunta@microsemi.com"
<RaghavaAditya.Renukunta@microsemi.com>,
"david.carroll@microsemi.com" <david.carroll@microsemi.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define
Date: Fri, 6 Jul 2018 17:01:00 +0000 [thread overview]
Message-ID: <b4f3bbb10b9e21b439e52c0f941809ca6f567bca.camel@wdc.com> (raw)
In-Reply-To: <20180706080447.2u3iptpnvmso6ncc@linux-x5ow.site>
On Fri, 2018-07-06 at 10:04 +0200, Johannes Thumshirn wrote:
> On Thu, Jul 05, 2018 at 05:24:23PM +0000, Bart Van Assche wrote:
> > On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote:
> > > if (((aac_cache & 6) == 6) && dev->cache_protected) {
> > > - scsicmd->result = AAC_STAT_GOOD;
> > > + scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 |
> > > + SAM_STAT_GOOD;
> >
> > Does AAC_STAT_GOOD really have to be expanded in full multiple times?
> > Have you considered to replace AAC_STAT_GOOD by the numerical constant
> > 0 instead?
>
> This won't work anymore once we start splitting ->result into 4
> unrelated enums. That's why I prefer this way.
That explanation does not make sense to me. There is plenty of code in
the upstream kernel that assigns zero to .result, so you will have to
deal with that pattern anyway.
Bart.
next prev parent reply other threads:[~2018-07-06 17:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 11:01 [PATCH 0/4] SCSI results rework preparation part 2 Johannes Thumshirn
2018-07-05 11:01 ` [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define Johannes Thumshirn
2018-07-05 17:24 ` Bart Van Assche
2018-07-06 8:04 ` Johannes Thumshirn
2018-07-06 17:01 ` Bart Van Assche [this message]
2018-07-05 17:42 ` Dave Carroll
2018-07-05 17:49 ` Bart Van Assche
2018-07-06 8:03 ` Johannes Thumshirn
2018-07-06 16:55 ` Dave Carroll
2018-07-05 11:01 ` [PATCH 2/4] scsi: bfa: remove ScsiResult macro Johannes Thumshirn
2018-07-05 17:00 ` Bart Van Assche
2018-07-06 8:08 ` Johannes Thumshirn
2018-07-05 11:01 ` [PATCH 3/4] scsi: lpfc: " Johannes Thumshirn
2018-07-05 17:02 ` Bart Van Assche
2018-07-05 11:01 ` [PATCH 4/4] scsi: ncr53c8xx: " Johannes Thumshirn
2018-07-05 17:04 ` Bart Van Assche
2018-07-06 8:09 ` Johannes Thumshirn
2018-07-06 17:05 ` Bart Van Assche
2018-07-09 7:15 ` Johannes Thumshirn
2018-07-11 2:53 ` [PATCH 0/4] SCSI results rework preparation part 2 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f3bbb10b9e21b439e52c0f941809ca6f567bca.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=david.carroll@microsemi.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®