From: Bart Van Assche <bart.vanassche@gmail.com>
To: Dave Carroll <david.carroll@microsemi.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Subject: Re: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define
Date: Thu, 5 Jul 2018 10:49:16 -0700 [thread overview]
Message-ID: <e0a3470a-6e52-5585-602e-0e515194b26d@gmail.com> (raw)
In-Reply-To: <4cd9a8cb64dc4d8aa1e10c3b008c3ba0@microsemi.com>
On 07/05/18 10:42, Dave Carroll wrote:
>> Remove the AAC_STAT_GOOD definition and open code it in the places it was
>> used.
>>
>> This will make subsequent refactoring in this area easier.
>>
> Please don't ... the definition itself was added to make refactoring easier.
That's a vague statement. Which kind of refactoring do you plan to make?
Bart.
next prev parent reply other threads:[~2018-07-05 17:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 11:01 [PATCH 0/4] SCSI results rework preparation part 2 Johannes Thumshirn
2018-07-05 11:01 ` [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define Johannes Thumshirn
2018-07-05 17:24 ` Bart Van Assche
2018-07-06 8:04 ` Johannes Thumshirn
2018-07-06 17:01 ` Bart Van Assche
2018-07-05 17:42 ` Dave Carroll
2018-07-05 17:49 ` Bart Van Assche [this message]
2018-07-06 8:03 ` Johannes Thumshirn
2018-07-06 16:55 ` Dave Carroll
2018-07-05 11:01 ` [PATCH 2/4] scsi: bfa: remove ScsiResult macro Johannes Thumshirn
2018-07-05 17:00 ` Bart Van Assche
2018-07-06 8:08 ` Johannes Thumshirn
2018-07-05 11:01 ` [PATCH 3/4] scsi: lpfc: " Johannes Thumshirn
2018-07-05 17:02 ` Bart Van Assche
2018-07-05 11:01 ` [PATCH 4/4] scsi: ncr53c8xx: " Johannes Thumshirn
2018-07-05 17:04 ` Bart Van Assche
2018-07-06 8:09 ` Johannes Thumshirn
2018-07-06 17:05 ` Bart Van Assche
2018-07-09 7:15 ` Johannes Thumshirn
2018-07-11 2:53 ` [PATCH 0/4] SCSI results rework preparation part 2 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a3470a-6e52-5585-602e-0e515194b26d@gmail.com \
--to=bart.vanassche@gmail.com \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=david.carroll@microsemi.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®