From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: Gustavo Foletto Mora <gusfmora@gmail.com>
Cc: linusw@kernel.org, andrew@lunn.ch, olteanv@gmail.com,
kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux@armlinux.org.uk, luizluca@gmail.com,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alvin.sipraga@analog.com,
kuncy7@gmail.com, fabianotassotti@gmail.com,
gabonpivovich@gmail.com, contact@c127.dev
Subject: Re: [PATCH net-next v12 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D
Date: Sat, 21 Nov 2026 02:30:41 +0100 [thread overview]
Message-ID: <b4f49c01-467b-4c16-bc47-b0f08ab48bce@yahoo.com> (raw)
In-Reply-To: <CAK+kzgycrbHcEpXZhLTPXdWtCUh+WwoBA0mC7CaS2HO7nM81vQ@mail.gmail.com>
On 20/11/2026 Gustavo Foletto Mora wrote:
> - Live vlan_filtering toggle on a bridge with a VLAN in use: IVL/SVL
> changes at once in both directions. [...] Each toggle that flips the
> switch-wide state took 20 to 30 ms.
> - The rollback added in v12 is an error path I could not provoke here.
>
> The rest of the series passes my regression test on this board as with
> v11: [...]
>
> Tested-by: Gustavo Foletto Mora <gusfmora@gmail.com>
Hi Gustavo,
Thank you for testing again, and for the timings.
In v13 I changed one thing in this patch after the automated review
(Sashiko) of v12: an entry that loses its last member could stay in
hardware with IVL_EN=1. rtl8365mb_vlan_4k_port_set() cleared its bit
in vlan_4k_used, so rtl8365mb_d_vlan_4k_refresh_ivl() never visited it
again, and after filtering was switched off, frames with that VID
would still have been looked up with IVL instead of SVL (FID 0).
On family D the emptied entry is now written back with IVL_EN cleared,
as in its reset state:
vlan4k.ivl_en = vlan4k.member &&
rtl8365mb_d_want_ivl(ds, -1, false);
The commit message and the comment in the code say so. Family C is
unchanged.
This path is only reached when the last port leaves a VLAN while
filtering is on (e.g. a port leaving a VLAN-aware bridge), which the
toggle test does not exercise, so I kept your Tested-by but would be
glad if you could re-run that case.
Best regards,
Mieczyslaw
next prev parent reply other threads:[~2026-11-21 1:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bc42ae96-dc7e-4b6e-b9cc-64cde5dc51ce.ref@yahoo.com>
2026-11-19 23:57 ` [PATCH net-next v12 00/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-19 23:58 ` [PATCH net-next v12 01/13] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-11-19 23:59 ` [PATCH net-next v12 02/13] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-11-20 0:00 ` [PATCH net-next v12 03/13] net: dsa: realtek: rtl8365mb: refactor forcemode handling Mieczyslaw Nalewaj
2026-11-20 0:01 ` [PATCH net-next v12 04/13] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-11-20 0:02 ` [PATCH net-next v12 05/13] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-11-20 0:03 ` [PATCH net-next v12 06/13] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling Mieczyslaw Nalewaj
2026-11-20 0:04 ` [PATCH net-next v12 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D Mieczyslaw Nalewaj
2026-11-20 14:17 ` Gustavo Foletto Mora
2026-11-21 1:30 ` Mieczyslaw Nalewaj [this message]
2026-11-20 0:05 ` [PATCH net-next v12 08/13] net: dsa: realtek: rtl8365mb: refactor PVID handling Mieczyslaw Nalewaj
2026-11-20 14:18 ` Gustavo Foletto Mora
2026-11-20 0:06 ` [PATCH net-next v12 09/13] net: dsa: realtek: rtl8365mb: use raw VID for PVID on family D Mieczyslaw Nalewaj
2026-11-20 14:26 ` Gustavo Foletto Mora
2026-11-20 0:07 ` [PATCH net-next v12 10/13] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-11-20 0:07 ` [PATCH net-next v12 11/13] net: dsa: realtek: rtl8365mb: refactor L2 MAC handling Mieczyslaw Nalewaj
2026-11-20 0:08 ` [PATCH net-next v12 12/13] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D Mieczyslaw Nalewaj
2026-11-20 0:09 ` [PATCH net-next v12 13/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-20 20:56 ` Gustavo Foletto Mora
2026-11-21 1:46 ` Mieczyslaw Nalewaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f49c01-467b-4c16-bc47-b0f08ab48bce@yahoo.com \
--to=namiltd@yahoo.com \
--cc=alvin.sipraga@analog.com \
--cc=andrew@lunn.ch \
--cc=contact@c127.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabianotassotti@gmail.com \
--cc=gabonpivovich@gmail.com \
--cc=gusfmora@gmail.com \
--cc=kuba@kernel.org \
--cc=kuncy7@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luizluca@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®