From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: Gustavo Foletto Mora <gusfmora@gmail.com>
Cc: linusw@kernel.org, andrew@lunn.ch, olteanv@gmail.com,
kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux@armlinux.org.uk, luizluca@gmail.com,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alvin.sipraga@analog.com,
kuncy7@gmail.com, fabianotassotti@gmail.com,
gabonpivovich@gmail.com, contact@c127.dev,
o.rempel@pengutronix.de
Subject: Re: [PATCH net-next v12 13/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB
Date: Sat, 21 Nov 2026 02:46:58 +0100 [thread overview]
Message-ID: <c848fe82-a534-410b-80a6-8d7fb35ab0ae@yahoo.com> (raw)
In-Reply-To: <CAK+kzgzzcGPWVoXQ=VKFeojk+-=9S_mWBhMdcN44M9QXkihn-g@mail.gmail.com>
On 21/11/2026 Gustavo Foletto Mora wrote:
> an untagged frame that the switch forwards to a port where its VLAN
> is egress-tagged leaves with PCP 1. [...] without the DCB series, it
> leaves with PCP 0.
> [...]
> So on this chip the PCP added to an untagged frame seems to follow the
> frame's internal priority (here the port priority), not 0x0851 [...]
Hi Gustavo,
Thank you for the detailed test and for narrowing it down to the
register values.
This series does not touch QoS, so I think the difference comes from
the DCB series. Reading rtl8365mb_qos_set_port_prio(), it does this on
every port, with no family check:
- writes iprio (IEEE8021Q_TT_BE, which is 1; Background is 0) to the
port priority register (0x0877..0x0878),
- writes untag_pcp (0 for Best Effort) to 0x0851..0x0852.
On family C both registers work, so an untagged frame gets PCP 0 and
internal priority 1. On family D, as you measured, 0x0851 has no
visible effect, and nothing in the backend programs an internal
priority -> PCP mapping. So the frame leaves with the PCP that matches
its internal priority, i.e. 1. That is what I expect from your data,
but I have not confirmed it on hardware.
Note that setting the port priority to 0 on family D would not be a fix:
that is Background internally, below what ingress PCP 0 gets, so
untagged traffic would be treated worse than tagged Best Effort.
Two questions, if you have time:
1. Does a non-zero value written to 0x0851 on your board change
anything (PCP of untagged frames, or the register reading back)?
The backend writes it unconditionally today.
2. Does the Realtek API in your stock firmware have an 802.1p
remarking table (internal priority -> PCP, with a per-port
enable) for this chip, and at which registers? If so, the family
D fix would be to program the inverse of the ingress mapping, so
that internal priority 1 leaves as PCP 0.
I do not plan to change anything in this series for this. I think it
should be raised against the DCB series (Oleksij Cc'd), unless you
see something in v13 that I missed.
Best regards,
Mieczyslaw
prev parent reply other threads:[~2026-11-21 1:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bc42ae96-dc7e-4b6e-b9cc-64cde5dc51ce.ref@yahoo.com>
2026-11-19 23:57 ` [PATCH net-next v12 00/13] " Mieczyslaw Nalewaj
2026-11-19 23:58 ` [PATCH net-next v12 01/13] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-11-19 23:59 ` [PATCH net-next v12 02/13] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-11-20 0:00 ` [PATCH net-next v12 03/13] net: dsa: realtek: rtl8365mb: refactor forcemode handling Mieczyslaw Nalewaj
2026-11-20 0:01 ` [PATCH net-next v12 04/13] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-11-20 0:02 ` [PATCH net-next v12 05/13] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-11-20 0:03 ` [PATCH net-next v12 06/13] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling Mieczyslaw Nalewaj
2026-11-20 0:04 ` [PATCH net-next v12 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D Mieczyslaw Nalewaj
2026-11-20 14:17 ` Gustavo Foletto Mora
2026-11-21 1:30 ` Mieczyslaw Nalewaj
2026-11-20 0:05 ` [PATCH net-next v12 08/13] net: dsa: realtek: rtl8365mb: refactor PVID handling Mieczyslaw Nalewaj
2026-11-20 14:18 ` Gustavo Foletto Mora
2026-11-20 0:06 ` [PATCH net-next v12 09/13] net: dsa: realtek: rtl8365mb: use raw VID for PVID on family D Mieczyslaw Nalewaj
2026-11-20 14:26 ` Gustavo Foletto Mora
2026-11-20 0:07 ` [PATCH net-next v12 10/13] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-11-20 0:07 ` [PATCH net-next v12 11/13] net: dsa: realtek: rtl8365mb: refactor L2 MAC handling Mieczyslaw Nalewaj
2026-11-20 0:08 ` [PATCH net-next v12 12/13] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D Mieczyslaw Nalewaj
2026-11-20 0:09 ` [PATCH net-next v12 13/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-20 20:56 ` Gustavo Foletto Mora
2026-11-21 1:46 ` Mieczyslaw Nalewaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c848fe82-a534-410b-80a6-8d7fb35ab0ae@yahoo.com \
--to=namiltd@yahoo.com \
--cc=alvin.sipraga@analog.com \
--cc=andrew@lunn.ch \
--cc=contact@c127.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabianotassotti@gmail.com \
--cc=gabonpivovich@gmail.com \
--cc=gusfmora@gmail.com \
--cc=kuba@kernel.org \
--cc=kuncy7@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luizluca@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®