From: Sandipan Das <sandipan.das@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jirka Hladky <jhladky@redhat.com>,
Breno Leitao <leitao@debian.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
leit@fb.com, dcostantino@meta.com,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-perf-users@vger.kernel.org>,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf/x86/amd: Do not WARN on every IRQ
Date: Thu, 14 Sep 2023 14:44:19 +0530 [thread overview]
Message-ID: <b5095128-2b10-4bd2-98aa-d5b04f412fc9@amd.com> (raw)
In-Reply-To: <20230914091234.GE16631@noisy.programming.kicks-ass.net>
On 9/14/2023 2:42 PM, Peter Zijlstra wrote:
> On Thu, Sep 14, 2023 at 02:25:40PM +0530, Sandipan Das wrote:
>> Hi Breno, Jirka,
>>
>> On 9/14/2023 2:15 PM, Jirka Hladky wrote:
>>> Hi Breno,
>>>
>>> I'm definitively voting for using WARN_ON_ONCE - in the current
>>> implementation, we are getting thousands of the same warnings and Call
>>> Traces, causing the system to become unusable.
>>>
>>>> Anyway, please let me know whatever is your preferred way and I will submit a v2.
>>> @Peter Zijlstra and @Sandipan - could you please comment on the
>>> preferred implementation of the patch?
>>>
>>
>> I agree with using WARN_ON_ONCE() to make this less intrusive.
>
> Could you send a patch that AMD is happy with? I think you wrote this
> was a firmware bug and is sorted with a new firmware, so perhaps make it
> WARN_ONCE() and tell the users to upgrade their firmware to $ver ?
Sure. Will do.
next prev parent reply other threads:[~2023-09-14 9:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 11:53 Breno Leitao
2023-06-16 13:29 ` Peter Zijlstra
2023-06-16 14:03 ` Breno Leitao
2023-06-16 14:43 ` Sandipan Das (AMD)
2023-06-16 15:32 ` Peter Zijlstra
2023-09-13 14:30 ` Jirka Hladky
2023-09-13 15:03 ` Breno Leitao
2023-09-13 15:23 ` Jirka Hladky
2023-09-13 16:18 ` Sandipan Das
2023-09-14 8:44 ` Jirka Hladky
[not found] ` <CAE4VaGAcWk0PYygNGcguRA2V2qK03entkv6BUsnxhS-ftdfywg@mail.gmail.com>
2023-09-14 8:49 ` Sandipan Das
2023-09-13 16:24 ` Breno Leitao
2023-09-14 8:45 ` Jirka Hladky
2023-09-14 8:55 ` Sandipan Das
2023-09-14 9:12 ` Peter Zijlstra
2023-09-14 9:14 ` Sandipan Das [this message]
2023-09-14 9:30 ` Breno Leitao
2023-09-14 11:18 ` Peter Zijlstra
2023-09-14 11:22 ` Sandipan Das
2023-09-14 11:27 ` Peter Zijlstra
2023-09-14 12:21 ` Breno Leitao
2023-09-14 13:50 ` Jirka Hladky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5095128-2b10-4bd2-98aa-d5b04f412fc9@amd.com \
--to=sandipan.das@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dcostantino@meta.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jhladky@redhat.com \
--cc=jolsa@kernel.org \
--cc=leit@fb.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome