mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tao Yi <escape@deepseek.com>
To: daejun7.park@samsung.com
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>,
	Matthew Wilcox <willy@infradead.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	"Liam R. Howlett" <liam@infradead.org>,
	Nico Pache <nico.pache@linux.dev>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	Usama Arif <usama.arif@linux.dev>,
	Kiryl Shutsemau <kas@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Brendan Jackman <brendan.jackman@linux.dev>,
	linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/2] mm: fix memcg_data reads during a THP split
Date: Fri, 6 Nov 2026 16:57:52 +0800	[thread overview]
Message-ID: <b58024d2-5e71-49c3-9aeb-15fceb0671e9@deepseek.com> (raw)
In-Reply-To: <20261104-kpagecgroup-split-v1-0-f70e947fec85@samsung.com>

Hi Daejun,

Sorry, I missed your email on the RFC thread. Thanks for following up
and for taking care of the fix.

在 2026/11/4 17:59, Daejun Park via B4 Relay 写道:
> Tao Yi reported an oops in page_cgroup_ino() while reading
> /proc/kpagecgroup and traced it to the THP split in an RFC [1]. The
> RFC skips frozen folios in the reader. Patch 1 moves the memcg_data
> copy in the split instead. Patch 2 orders the same loads in
> page_owner and needs patch 1.
>
> Charged large kmalloc pages are frozen, so the RFC would report them
> as uncharged. My review of the RFC [2] got no reply. Tested on x86_64
> with KASAN, see patch 1.
>
> [1] https://lore.kernel.org/all/20260907124001.1544655-1-escape@deepseek.com/
> [2] https://lore.kernel.org/all/20261028040418epcms2p7ac0f584cdfdc6a0ea9b7f20eadeada3d@epcms2p7/
>
> ---
> Daejun Park (2):
>        mm/huge_memory: set memcg_data before a split page leaves the folio
>        mm/page_owner: also check PageTail before reading memcg_data
>
>   mm/huge_memory.c | 17 +++++++++++++----
>   mm/memcontrol.c  |  9 ++++++++-
>   mm/page_owner.c  |  7 +++++++
>   3 files changed, 28 insertions(+), 5 deletions(-)
> ---
> base-commit: a13b500946e5dc467976838572b8ddd2fd777ca7
> change-id: 20261028-kpagecgroup-split-8a749c6ee27e
>
> Best regards,

      parent reply	other threads:[~2026-11-06  8:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  9:59 Daejun Park via B4 Relay
2026-11-04  9:59 ` [PATCH 1/2] mm/huge_memory: set memcg_data before a split page leaves the folio Daejun Park via B4 Relay
2026-11-04 16:33   ` Zi Yan
     [not found]   ` <CGME20261104163327epcas2p1f056cd220dc0d3e40e6fcea082f01b74@epcms2p6>
2026-11-05  1:06     ` Daejun Park
2026-11-04  9:59 ` [PATCH 2/2] mm/page_owner: also check PageTail before reading memcg_data Daejun Park via B4 Relay
2026-11-04 16:38   ` Zi Yan
2026-11-06  8:57 ` Tao Yi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b58024d2-5e71-49c3-9aeb-15fceb0671e9@deepseek.com \
    --to=escape@deepseek.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brendan.jackman@linux.dev \
    --cc=cgroups@vger.kernel.org \
    --cc=daejun7.park@samsung.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=kas@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=shakeel.butt@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®