From: Heiner Kallweit <hkallweit1@gmail.com>
To: Crag Wang <crag0715@gmail.com>
Cc: nic_swsd@realtek.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
crag.wang@dell.com, dell.client.kernel@dell.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] r8169: add module parameter aspm_en_force
Date: Mon, 21 Apr 2025 10:45:58 +0200 [thread overview]
Message-ID: <b580bd83-3c15-482e-858e-09f298c41326@gmail.com> (raw)
In-Reply-To: <CAP-8N0jAjeY8Wthta1yS8Hs57KKt6HyFWpYM6=q1t+jxF_sY1A@mail.gmail.com>
On 21.04.2025 10:17, Crag Wang wrote:
>
> Adding module parameters is discouraged.
> Also note that you have the option already to re-activate ASPM, you can use the
> standard PCI sysfs attributes under /sys/class/net/<if>/device/link for this.
>
>
> How about adding a quirk table for the matched DMI patterns, allowing the hardware
> makers to opt-in ASPM settings in the kernel segment as an alternative to the PCI sysfs?
>
There is already such an option, see rtl_aspm_is_safe().
prev parent reply other threads:[~2025-04-21 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:55 Crag Wang
2025-03-24 13:27 ` Heiner Kallweit
2025-04-21 8:20 ` Crag Wang
[not found] ` <CAP-8N0jAjeY8Wthta1yS8Hs57KKt6HyFWpYM6=q1t+jxF_sY1A@mail.gmail.com>
2025-04-21 8:45 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b580bd83-3c15-482e-858e-09f298c41326@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=crag.wang@dell.com \
--cc=crag0715@gmail.com \
--cc=davem@davemloft.net \
--cc=dell.client.kernel@dell.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®