* Re: [PATCH] ppp: Pass PPP Kconfig defines through to the CPP
[not found] <20250331194918.385248-1-steve@snewbury.org.uk>
@ 2025-04-01 14:26 ` Andrew Lunn
0 siblings, 0 replies; only message in thread
From: Andrew Lunn @ 2025-04-01 14:26 UTC (permalink / raw)
To: steve
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
On Mon, Mar 31, 2025 at 08:49:16PM +0100, steve@snewbury.org.uk wrote:
> From: Steven Newbury <steve@snewbury.org.uk>
>
> It seems for a very long time the conditional code in ppp_generic.c for PPP_MULTILINK
> and PPP_FILTER hasn't been compiled! I do wonder whether anybody actually still uses
> these options!
> ---
> drivers/net/ppp/Makefile | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ppp/Makefile b/drivers/net/ppp/Makefile
> index 16c457d6b324..9d12915e4ac5 100644
> --- a/drivers/net/ppp/Makefile
> +++ b/drivers/net/ppp/Makefile
> @@ -12,3 +12,10 @@ obj-$(CONFIG_PPP_SYNC_TTY) += ppp_synctty.o
> obj-$(CONFIG_PPPOE) += pppox.o pppoe.o
> obj-$(CONFIG_PPPOL2TP) += pppox.o
> obj-$(CONFIG_PPTP) += pppox.o pptp.o
> +
> +ifdef CONFIG_PPP_MULTILINK
> +ccflags-y += -DCONFIG_PPP_MULTILINK
> +endif
> +ifdef CONFIG_PPP_FILTER
> +ccflags-y += -DCONFIG_PPP_FILTER
> +endif
That looks very odd. I don't see many other instances for Makefiles
doing this. Please add a bigger explanation of why this is needed, and
why the usual Kconfig mechanism don't work.
Andrew
---
pw-bot: cr
^ permalink raw reply [flat|nested] only message in thread