* [PATCH] nbd: kill unused ret in recv_work
@ 2017-07-13 11:20 Kefeng Wang
2017-07-13 14:03 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Kefeng Wang @ 2017-07-13 11:20 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-kernel, linux-block, Kefeng Wang
No need to return value in queue work, kill ret variable.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/block/nbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index dea7d85..87a0a29 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -626,7 +626,6 @@ static void recv_work(struct work_struct *work)
struct nbd_device *nbd = args->nbd;
struct nbd_config *config = nbd->config;
struct nbd_cmd *cmd;
- int ret = 0;
while (1) {
cmd = nbd_read_stat(nbd, args->index);
@@ -636,7 +635,6 @@ static void recv_work(struct work_struct *work)
mutex_lock(&nsock->tx_lock);
nbd_mark_nsock_dead(nbd, nsock, 1);
mutex_unlock(&nsock->tx_lock);
- ret = PTR_ERR(cmd);
break;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nbd: kill unused ret in recv_work
2017-07-13 11:20 [PATCH] nbd: kill unused ret in recv_work Kefeng Wang
@ 2017-07-13 14:03 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2017-07-13 14:03 UTC (permalink / raw)
To: Kefeng Wang, Josef Bacik; +Cc: linux-kernel, linux-block
On 07/13/2017 05:20 AM, Kefeng Wang wrote:
> No need to return value in queue work, kill ret variable.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-13 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13 11:20 [PATCH] nbd: kill unused ret in recv_work Kefeng Wang
2017-07-13 14:03 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome