mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Mario_Limonciello@Dell.com>
To: <gregkh@linuxfoundation.org>
Cc: <hayeswang@realtek.com>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<pali.rohar@gmail.com>, <anthony.wong@canonical.com>
Subject: RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address
Date: Fri, 3 Jun 2016 15:10:32 +0000	[thread overview]
Message-ID: <b6171d35838941e792d846802007ad88@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <20160603020139.GA3668@kroah.com>

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, June 2, 2016 9:02 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: hayeswang@realtek.com; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; linux-usb@vger.kernel.org; pali.rohar@gmail.com;
> anthony.wong@canonical.com
> Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's
> Auxiliary MAC address
> 
> On Thu, Jun 02, 2016 at 06:32:42PM +0000, Mario_Limonciello@Dell.com
> wrote:
> > > And you want to check this for all Dell devices?  Please be model
> > > specific, I doubt a bunch of Dell servers wants to run this code...
> > >
> >
> > Tracking model specific is really going to turn into a giant list never ending
> list.
> > To drill down more specifically, I can match on chassis too.
> 
> Yes, as this is a vendor/platform-specific "quirk", you will have to
> update it for each and every individual device you want it enabled as it
> is so different from what all other drivers do.
> 
> thanks,
> 
> greg k-h

After finding out that there is a characteristic specific to Realtek chip in this USB
device, I think it would be best to only run the \\_SB.AMAC lookup when this 
specific USB device is connected.  

Realtek is not maintaining a whitelist of systems in their driver for the other OS,
they approach it from the other end and only lookup auxiliary MAC if the right
device is plugged in.

  reply	other threads:[~2016-06-03 15:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 16:58 Mario Limonciello
2016-06-02 16:58 ` Mario Limonciello
2016-06-02 17:48   ` Greg KH
2016-06-02 18:32     ` Mario_Limonciello
2016-06-02 19:02       ` Andrew Lunn
2016-06-02 19:04         ` Mario_Limonciello
2016-06-02 19:09           ` Andrew Lunn
2016-06-03 14:44             ` Mario_Limonciello
2016-06-03  2:01       ` Greg KH
2016-06-03 15:10         ` Mario_Limonciello [this message]
2016-06-03  9:43   ` Hayes Wang
2016-06-03 15:08     ` Mario_Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6171d35838941e792d846802007ad88@ausx13mpc124.AMER.DELL.COM \
    --to=mario_limonciello@dell.com \
    --cc=anthony.wong@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®