* [PATCH] ASoC: qcom: q6asm: Correct the 24-bit capture format
@ 2026-11-01 19:05 Michael McAllister
2026-11-04 20:47 ` Demeter Barna
0 siblings, 1 reply; 7+ messages in thread
From: Michael McAllister @ 2026-11-01 19:05 UTC (permalink / raw)
To: Srinivas Kandagatla, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-sound,
linux-arm-msm, linux-kernel, Michael McAllister
Recording in S24_LE on my Moto G10 produces badly scaled samples that
wrap at full scale. The PCM V2 DSP interface places 24-bit samples in
bits 31:8 of each 32-bit word, but ALSA S24_LE expects bits 23:0.
Replace S24_LE with S32_LE for capture and constrain it to 24
significant bits. Keep the DSP configured for 24-bit samples. This
matches its native layout without converting samples in the kernel.
Playback is unchanged.
Translate S32_LE back to S24_LE in the APQ8096 and SC7180 backend
fixups so that routing and the physical audio ports keep their 24-bit
width. The other Q6ASM machine drivers already set the backend format.
Tested on the Moto G10 with direct ALSA and PipeWire capture at 48 kHz,
using 16-bit and 32-bit containers, reopening the stream, and recording
after suspend. ALSA reports 24 significant bits for S32_LE. S24_LE
capture through ALSA's plug conversion also works.
Signed-off-by: Michael McAllister <me@michaelmcallister.org>
---
Hi,
I found this while getting the microphone working on my Moto G10
(SM4250). This fixes the incorrect sample format for 24-bit capture;
I've tested it with ALSA and PipeWire, including after suspend.
The APQ8096 and SC7180 changes have only been build-tested, so testing
on those boards would be appreciated.
Thanks,
Michael
sound/soc/qcom/apq8096.c | 8 ++++++++
sound/soc/qcom/qdsp6/q6asm-dai.c | 12 ++++++++++--
sound/soc/qcom/sc7180.c | 8 ++++++++
3 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
index cfd6438db..25f2f0c0e 100644
--- a/sound/soc/qcom/apq8096.c
+++ b/sound/soc/qcom/apq8096.c
@@ -6,6 +6,7 @@
#include <sound/soc.h>
#include <sound/soc-dapm.h>
#include <sound/pcm.h>
+#include <sound/pcm_params.h>
#include "common.h"
#define SLIM_MAX_TX_PORTS 16
@@ -19,10 +20,17 @@ static int apq8096_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
SNDRV_PCM_HW_PARAM_RATE);
struct snd_interval *channels = hw_param_interval(params,
SNDRV_PCM_HW_PARAM_CHANNELS);
+ struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
rate->min = rate->max = 48000;
channels->min = channels->max = 2;
+ /* Keep the backend at 24 bits despite the 32-bit capture container. */
+ if (params_format(params) == SNDRV_PCM_FORMAT_S32_LE) {
+ snd_mask_none(fmt);
+ snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S24_LE);
+ }
+
return 0;
}
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index 4261c3048..4bed05f0d 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -90,7 +90,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_capture = {
SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
.formats = (SNDRV_PCM_FMTBIT_S16_LE |
- SNDRV_PCM_FMTBIT_S24_LE),
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_48000,
.rate_min = 8000,
.rate_max = 48000,
@@ -151,7 +151,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
SNDRV_PCM_RATE_12000 | \
SNDRV_PCM_RATE_24000), \
.formats = (SNDRV_PCM_FMTBIT_S16_LE | \
- SNDRV_PCM_FMTBIT_S24_LE), \
+ SNDRV_PCM_FMTBIT_S32_LE), \
.channels_min = 1, \
.channels_max = 4, \
.rate_min = 8000, \
@@ -377,6 +377,13 @@ static int q6asm_dai_open(struct snd_soc_component *component,
stream_id = cpu_dai->driver->id;
+ if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
+ /* The DSP stores 24-bit samples in the high bits of 32-bit words. */
+ ret = snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
+ if (ret < 0)
+ return ret;
+ }
+
pdata = snd_soc_component_get_drvdata(component);
if (!pdata) {
dev_err(dev, "Drv data not found ..\n");
@@ -506,6 +513,7 @@ static int q6asm_dai_hw_params(struct snd_soc_component *component,
prtd->bits_per_sample = 16;
break;
case SNDRV_PCM_FORMAT_S24_LE:
+ case SNDRV_PCM_FORMAT_S32_LE:
prtd->bits_per_sample = 24;
break;
}
diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c
index bc5a18883..9e4bd9855 100644
--- a/sound/soc/qcom/sc7180.c
+++ b/sound/soc/qcom/sc7180.c
@@ -13,6 +13,7 @@
#include <sound/core.h>
#include <sound/jack.h>
#include <sound/pcm.h>
+#include <sound/pcm_params.h>
#include <sound/soc.h>
#include <uapi/linux/input-event-codes.h>
@@ -425,10 +426,17 @@ static int sc7180_qdsp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
SNDRV_PCM_HW_PARAM_RATE);
struct snd_interval *channels = hw_param_interval(params,
SNDRV_PCM_HW_PARAM_CHANNELS);
+ struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
rate->min = rate->max = 48000;
channels->min = channels->max = 2;
+ /* Keep the backend at 24 bits despite the 32-bit capture container. */
+ if (params_format(params) == SNDRV_PCM_FORMAT_S32_LE) {
+ snd_mask_none(fmt);
+ snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S24_LE);
+ }
+
return 0;
}
base-commit: 46fec1c3029b552ec63b2d01af9d43a386f043ea
--
2.39.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: qcom: q6asm: Correct the 24-bit capture format
2026-11-01 19:05 [PATCH] ASoC: qcom: q6asm: Correct the 24-bit capture format Michael McAllister
@ 2026-11-04 20:47 ` Demeter Barna
2026-11-08 18:03 ` [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format Michael McAllister
0 siblings, 1 reply; 7+ messages in thread
From: Demeter Barna @ 2026-11-04 20:47 UTC (permalink / raw)
To: Michael McAllister
Cc: Srinivas Kandagatla, Mark Brown, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, linux-sound, linux-arm-msm, linux-kernel
On 2026-11-01 19:05, Michael McAllister wrote:
> Recording in S24_LE on my Moto G10 produces badly scaled samples that
> wrap at full scale. The PCM V2 DSP interface places 24-bit samples in
> bits 31:8 of each 32-bit word, but ALSA S24_LE expects bits 23:0.
I see the same on SM8350 with v7.4-rc1. Without the patch, S24_LE
recordings from the DMICs wrap at full scale, while the actual signal
sits in the upper 24 bits. With it, capture offers S32_LE with 24
significant bits, the recording matches the S16_LE one, and both
PipeWire and plughw work.
Playback has the same problem: the DSP also takes 24-bit samples from
the upper 24 bits, so S24_LE playback comes out barely audible. Offering
S32_LE with 24 significant bits for playback as well brings it to the
expected level. I suspect this has gone unnoticed because userspace
hides it: distributions for these devices tend to force S16LE in their
PipeWire configuration to work around quiet audio.
Would you like to cover playback in a v2, or should I send a playback
patch on top of yours?
Tested-by: Demeter Barna <me@fromdisposition.org> # SM8350
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format
2026-11-04 20:47 ` Demeter Barna
@ 2026-11-08 18:03 ` Michael McAllister
2026-11-15 13:12 ` Srinivas Kandagatla
0 siblings, 1 reply; 7+ messages in thread
From: Michael McAllister @ 2026-11-08 18:03 UTC (permalink / raw)
To: Demeter Barna, Srinivas Kandagatla, Mark Brown
Cc: lgirdwood, perex, tiwai, linux-sound, linux-arm-msm, linux-kernel, me
Recording in S24_LE on the Moto G10 produces badly scaled samples that
wrap at full scale. Playback has the same layout problem and comes out
barely audible. The PCM V2 DSP interface uses bits 31:8 of each 32-bit
word for 24-bit samples, but ALSA S24_LE expects bits 23:0.
Replace S24_LE with S32_LE for playback and capture and constrain it
to 24 significant bits. Keep the DSP configured for 24-bit samples.
This matches its native layout without converting samples in the kernel.
Translate S32_LE back to S24_LE in the APQ8096 and SC7180 backend
fixups so that routing and the physical audio ports keep their 24-bit
width. The other Q6ASM machine drivers already set the backend format.
Raw S24_LE requests are no longer supported. Applications using that
format need S32_LE or a converting PCM device such as plughw.
Tested on the Moto G10 with direct ALSA and PipeWire playback/capture
at 48 kHz, including reopening streams and testing after suspend.
Direct S32_LE playback now matches the S16_LE level, ALSA reports
24 significant bits, and S24_LE through plug conversion works.
Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver")
Reported-by: Demeter Barna <me@fromdisposition.org>
Closes: https://lore.kernel.org/f3485a790ffdafe635b84b5d68730dad@fromdisposition.org/
Signed-off-by: Michael McAllister <me@michaelmcallister.org>
---
Hi, thanks Demeter! I was able to reproduce this too, and I've included
a fix for playback in v2.
Changes in v2:
- Cover playback as well as capture.
- Remove the unused S24_LE case and update the backend comments.
- Add Fixes and Reported-by, and document the raw-format change.
- Rebase onto sound/for-next.
v1: https://lore.kernel.org/179355993304.51321.11135059681945648585.q6asm-capture-format-v1@michaelmcallister.org/
sound/soc/qcom/apq8096.c | 8 ++++++++
sound/soc/qcom/qdsp6/q6asm-dai.c | 15 ++++++++++-----
sound/soc/qcom/sc7180.c | 8 ++++++++
3 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
index cfd6438db..b7030f7ef 100644
--- a/sound/soc/qcom/apq8096.c
+++ b/sound/soc/qcom/apq8096.c
@@ -6,6 +6,7 @@
#include <sound/soc.h>
#include <sound/soc-dapm.h>
#include <sound/pcm.h>
+#include <sound/pcm_params.h>
#include "common.h"
#define SLIM_MAX_TX_PORTS 16
@@ -19,10 +20,17 @@ static int apq8096_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
SNDRV_PCM_HW_PARAM_RATE);
struct snd_interval *channels = hw_param_interval(params,
SNDRV_PCM_HW_PARAM_CHANNELS);
+ struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
rate->min = rate->max = 48000;
channels->min = channels->max = 2;
+ /* Keep the backend at 24 bits despite the 32-bit PCM container. */
+ if (params_format(params) == SNDRV_PCM_FORMAT_S32_LE) {
+ snd_mask_none(fmt);
+ snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S24_LE);
+ }
+
return 0;
}
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index 4261c3048..cd97ba2ff 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -90,7 +90,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_capture = {
SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
.formats = (SNDRV_PCM_FMTBIT_S16_LE |
- SNDRV_PCM_FMTBIT_S24_LE),
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_48000,
.rate_min = 8000,
.rate_max = 48000,
@@ -113,7 +113,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
.formats = (SNDRV_PCM_FMTBIT_S16_LE |
- SNDRV_PCM_FMTBIT_S24_LE),
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_192000,
.rate_min = 8000,
.rate_max = 192000,
@@ -139,7 +139,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
SNDRV_PCM_RATE_176400 | \
SNDRV_PCM_RATE_192000), \
.formats = (SNDRV_PCM_FMTBIT_S16_LE | \
- SNDRV_PCM_FMTBIT_S24_LE), \
+ SNDRV_PCM_FMTBIT_S32_LE), \
.channels_min = 1, \
.channels_max = 8, \
.rate_min = 8000, \
@@ -151,7 +151,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
SNDRV_PCM_RATE_12000 | \
SNDRV_PCM_RATE_24000), \
.formats = (SNDRV_PCM_FMTBIT_S16_LE | \
- SNDRV_PCM_FMTBIT_S24_LE), \
+ SNDRV_PCM_FMTBIT_S32_LE), \
.channels_min = 1, \
.channels_max = 4, \
.rate_min = 8000, \
@@ -377,6 +377,11 @@ static int q6asm_dai_open(struct snd_soc_component *component,
stream_id = cpu_dai->driver->id;
+ /* The DSP uses the high 24 bits of each 32-bit word. */
+ ret = snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
+ if (ret < 0)
+ return ret;
+
pdata = snd_soc_component_get_drvdata(component);
if (!pdata) {
dev_err(dev, "Drv data not found ..\n");
@@ -505,7 +510,7 @@ static int q6asm_dai_hw_params(struct snd_soc_component *component,
case SNDRV_PCM_FORMAT_S16_LE:
prtd->bits_per_sample = 16;
break;
- case SNDRV_PCM_FORMAT_S24_LE:
+ case SNDRV_PCM_FORMAT_S32_LE:
prtd->bits_per_sample = 24;
break;
}
diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c
index bc5a18883..dd0f8eb99 100644
--- a/sound/soc/qcom/sc7180.c
+++ b/sound/soc/qcom/sc7180.c
@@ -13,6 +13,7 @@
#include <sound/core.h>
#include <sound/jack.h>
#include <sound/pcm.h>
+#include <sound/pcm_params.h>
#include <sound/soc.h>
#include <uapi/linux/input-event-codes.h>
@@ -425,10 +426,17 @@ static int sc7180_qdsp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
SNDRV_PCM_HW_PARAM_RATE);
struct snd_interval *channels = hw_param_interval(params,
SNDRV_PCM_HW_PARAM_CHANNELS);
+ struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
rate->min = rate->max = 48000;
channels->min = channels->max = 2;
+ /* Keep the backend at 24 bits despite the 32-bit PCM container. */
+ if (params_format(params) == SNDRV_PCM_FORMAT_S32_LE) {
+ snd_mask_none(fmt);
+ snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S24_LE);
+ }
+
return 0;
}
base-commit: c937f492dd40a8398d955cf0f4f9e11d7268bcb5
--
2.39.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format
2026-11-08 18:03 ` [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format Michael McAllister
@ 2026-11-15 13:12 ` Srinivas Kandagatla
2026-11-16 9:20 ` Demeter Barna
0 siblings, 1 reply; 7+ messages in thread
From: Srinivas Kandagatla @ 2026-11-15 13:12 UTC (permalink / raw)
To: Michael McAllister, Demeter Barna, Srinivas Kandagatla, Mark Brown
Cc: lgirdwood, perex, tiwai, linux-sound, linux-arm-msm, linux-kernel
On 11/8/26 6:03 PM, Michael McAllister wrote:
> Recording in S24_LE on the Moto G10 produces badly scaled samples that
> wrap at full scale. Playback has the same layout problem and comes out
> barely audible. The PCM V2 DSP interface uses bits 31:8 of each 32-bit
> word for 24-bit samples, but ALSA S24_LE expects bits 23:0.
>
> Replace S24_LE with S32_LE for playback and capture and constrain it
> to 24 significant bits. Keep the DSP configured for 24-bit samples.
> This matches its native layout without converting samples in the kernel.
>
> Translate S32_LE back to S24_LE in the APQ8096 and SC7180 backend
> fixups so that routing and the physical audio ports keep their 24-bit
> width. The other Q6ASM machine drivers already set the backend format.
>
> Raw S24_LE requests are no longer supported. Applications using that
> format need S32_LE or a converting PCM device such as plughw.
>
> Tested on the Moto G10 with direct ALSA and PipeWire playback/capture
> at 48 kHz, including reopening streams and testing after suspend.
> Direct S32_LE playback now matches the S16_LE level, ALSA reports
> 24 significant bits, and S24_LE through plug conversion works.
>
> Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver")
> Reported-by: Demeter Barna <me@fromdisposition.org>
> Closes: https://lore.kernel.org/f3485a790ffdafe635b84b5d68730dad@fromdisposition.org/
>
> Signed-off-by: Michael McAllister <me@michaelmcallister.org>
> ---
> Hi, thanks Demeter! I was able to reproduce this too, and I've included
> a fix for playback in v2.
Thankyou both for bringing this up, However the patch seems to be done
to fix the issue in wrong way. This is the dsp configuration issue afaiu.
we have ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V4 which should allow us to
specify the bit per sample an sample words and also alignment.
Can you please try this change and see if it helps. I have not tested
this myself as am travelling atm.
-------------------------------------->cut<--------------------------
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Date: Sun Nov 15 12:56:59 2026 +0000
ASoC: qdsp6: q6asm: use MULTI_CHANNEL_PCM_V4 for correct S24_LE layout
The ADSP V2 PCM format block (asm_multi_channel_pcm_fmt_blk_v2) carries
only bits_per_sample and has no way to describe how 24-bit samples are
positioned inside a 32-bit container. When the driver sends
bits_per_sample = 24 the firmware walks the buffer using its own
convention (packed 3-byte or MSB-aligned-in-32), neither of which
matches ALSA SNDRV_PCM_FORMAT_S24_LE (24 bits LSB-aligned in a 32-bit
word, i.e. 8.24 / Q23). The result is scaled/wrapping samples on both
playback and capture.
The V3 PCM format block adds sample_word_size but, per the ADSP ABI
documentation, with bits_per_sample = 24 and sample_word_size = 32 it
places samples in the *most significant* 24 bits of the 32-bit word
(Q31 default). V3 still cannot describe 8.24 / LSB-aligned 24-in-32.
The V4 PCM format block adds endianness and a "mode" field that is
exactly a Q-factor / alignment selector. Mode 23 means "24-bit packed
or 8.24 format" - the latter matches ALSA S24_LE: 24 valid bits in
bits 23:0 of a 32-bit word. Use V4 with
bits_per_sample = 24
sample_word_size = 32
endianness = little
mode = 23
for S24_LE and defaults (mode = 0) for S16_LE/S32_LE.
Note that the MEDIA_FMT_UPDATE opcode stays
ASM_DATA_CMD_MEDIA_FMT_UPDATE_V2
(0x00010D98); there is no dedicated V4 variant of the update command on
the ADSP ABI - V4-ness is carried by the format-id in the payload
(ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V4 = 0x0001320C). This matches
Qualcomm's downstream audio-kernel implementation.
This keeps SNDRV_PCM_FMTBIT_S24_LE advertised and avoids any UAPI
change.
Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver")
Cc: stable@vger.kernel.org
Signed-off-by: Srinivas Kandagatla
<srinivas.kandagatla@oss.qualcomm.com>
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c
b/sound/soc/qcom/qdsp6/q6asm-dai.c
index dc5230f13a97..930080e7c7b4 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -209,6 +209,7 @@ static int q6asm_dai_prepare(struct
snd_soc_component *component,
struct q6asm_dai_rtd *prtd = runtime->private_data;
struct q6asm_dai_data *pdata;
struct device *dev = component->dev;
+ u16 word_size, mode;
int ret, i;
pdata = snd_soc_component_get_drvdata(component);
@@ -277,17 +278,32 @@ static int q6asm_dai_prepare(struct
snd_soc_component *component,
goto routing_err;
}
+ /*
+ * SNDRV_PCM_FORMAT_S24_LE is 24 valid bits in a 32-bit container,
+ * LSB-aligned (8.24 / Q23). Set the DSP accordingly via V4 mode
= 23.
+ * All other advertised formats are packed (container == valid bits,
+ * default QF).
+ */
+ if (prtd->bits_per_sample == 24) {
+ word_size = 32;
+ mode = 23;
+ } else {
+ word_size = prtd->bits_per_sample;
+ mode = 0;
+ }
+
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
- ret = q6asm_media_format_block_multi_ch_pcm(
+ ret = q6asm_media_format_block_multi_ch_pcm_v4(
prtd->audio_client, prtd->stream_id,
runtime->rate, runtime->channels, NULL,
- prtd->bits_per_sample);
+ prtd->bits_per_sample, word_size, mode);
} else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
- ret =
q6asm_enc_cfg_blk_pcm_format_support(prtd->audio_client,
+ ret =
q6asm_enc_cfg_blk_pcm_format_support_v4(prtd->audio_client,
prtd->stream_id,
runtime->rate,
runtime->channels,
-
prtd->bits_per_sample);
+
prtd->bits_per_sample,
+ word_size, mode);
/* Queue the buffers */
for (i = 0; i < runtime->periods; i++)
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
index 3f9f2448eb32..edd1ec066765 100644
--- a/sound/soc/qcom/qdsp6/q6asm.c
+++ b/sound/soc/qcom/qdsp6/q6asm.c
@@ -40,6 +40,18 @@
#define ASM_PARAM_ID_ENCDEC_ENC_CFG_BLK_V2 0x00010DA3
#define ASM_SESSION_CMD_RUN_V2 0x00010DAA
#define ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V2 0x00010DA5
+#define ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V4 0x0001320C
+/*
+ * V4 PCM mode: "Q factor" / alignment selector.
+ * 0 - Default QFs (Q15 for 16b, Q23 for packed 24b, Q31 for unpacked
+ * 24b or 32b). For 24-in-32 the default is Q31 (MSB-aligned).
+ * 15 - explicit Q15 for 16-bit
+ * 23 - Q23 / 8.24 format: 24 valid bits LSB-aligned in a 32-bit word
+ * (matches ALSA SNDRV_PCM_FORMAT_S24_LE).
+ */
+#define ASM_PCM_MODE_DEFAULT_Q 0
+#define ASM_PCM_MODE_Q23_OR_PACKED_24 23
+#define ASM_PCM_ENDIAN_LITTLE 0
#define ASM_MEDIA_FMT_MP3 0x00010BE9
#define ASM_MEDIA_FMT_FLAC 0x00010C16
#define ASM_MEDIA_FMT_WMA_V9 0x00010DA8
@@ -99,6 +111,29 @@ struct asm_multi_channel_pcm_fmt_blk_v2 {
u8 channel_mapping[PCM_MAX_NUM_CHANNEL];
} __packed;
+/*
+ * V4 PCM format block adds sample_word_size (container width), endianness,
+ * and mode. For "24 valid bits in a 32-bit container, LSB-aligned" (i.e.
+ * ALSA SNDRV_PCM_FORMAT_S24_LE = 8.24 format), set
+ * bits_per_sample = 24
+ * sample_word_size = 32
+ * endianness = 0 (little)
+ * mode = 23 (Q23 / 8.24)
+ * With mode = 0 (default QFs), 24-in-32 is Q31 / MSB-aligned, which does
+ * not match ALSA S24_LE.
+ */
+struct asm_multi_channel_pcm_fmt_blk_v4 {
+ struct asm_data_cmd_media_fmt_update_v2 fmt_blk;
+ u16 num_channels;
+ u16 bits_per_sample;
+ u32 sample_rate;
+ u16 is_signed;
+ u16 sample_word_size;
+ u8 channel_mapping[PCM_MAX_NUM_CHANNEL];
+ u16 endianness;
+ u16 mode;
+} __packed;
+
struct asm_flac_fmt_blk_v2 {
struct asm_data_cmd_media_fmt_update_v2 fmt_blk;
u16 is_stream_info_present;
@@ -191,6 +226,20 @@ struct asm_multi_channel_pcm_enc_cfg_v2 {
uint8_t channel_mapping[8];
} __packed;
+/* V4 capture enc-cfg: adds sample_word_size, endianness, mode. */
+struct asm_multi_channel_pcm_enc_cfg_v4 {
+ struct asm_stream_cmd_set_encdec_param encdec;
+ struct asm_enc_cfg_blk_param_v2 encblk;
+ u16 num_channels;
+ u16 bits_per_sample;
+ u32 sample_rate;
+ u16 is_signed;
+ u16 sample_word_size;
+ u8 channel_mapping[8];
+ u16 endianness;
+ u16 mode;
+} __packed;
+
struct asm_data_cmd_read_v2 {
u32 buf_addr_lsw;
u32 buf_addr_msw;
@@ -953,7 +1002,7 @@ int q6asm_open_write(struct audio_client *ac,
uint32_t stream_id,
open->dec_fmt_id = ASM_MEDIA_FMT_MP3;
break;
case FORMAT_LINEAR_PCM:
- open->dec_fmt_id = ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V2;
+ open->dec_fmt_id = ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V4;
break;
case SND_AUDIOCODEC_FLAC:
open->dec_fmt_id = ASM_MEDIA_FMT_FLAC;
@@ -1121,6 +1170,60 @@ int q6asm_media_format_block_multi_ch_pcm(struct
audio_client *ac,
}
EXPORT_SYMBOL_GPL(q6asm_media_format_block_multi_ch_pcm);
+/**
+ * q6asm_media_format_block_multi_ch_pcm_v4() - setup PCM configuration
(V4)
+ *
+ * @ac: audio client pointer
+ * @stream_id: stream id
+ * @rate: audio sample rate
+ * @channels: number of audio channels
+ * @channel_map: channel map pointer (optional)
+ * @bits_per_sample: valid bits per sample (e.g. 24 for S24_LE)
+ * @sample_word_size: container size in bits (e.g. 32 for S24_LE, 16
for S16_LE)
+ * @mode: Q factor / alignment selector; use ASM_PCM_MODE_Q23_OR_PACKED_24
+ * for ALSA SNDRV_PCM_FORMAT_S24_LE (24 bits LSB-aligned in
32-bit word).
+ *
+ * Return: 0 on success, negative errno on failure.
+ */
+int q6asm_media_format_block_multi_ch_pcm_v4(struct audio_client *ac,
+ uint32_t stream_id,
+ uint32_t rate, uint32_t
channels,
+ u8
channel_map[PCM_MAX_NUM_CHANNEL],
+ uint16_t bits_per_sample,
+ uint16_t sample_word_size,
+ uint16_t mode)
+{
+ struct asm_multi_channel_pcm_fmt_blk_v4 *fmt;
+ struct apr_pkt *pkt;
+ int pkt_size = APR_HDR_SIZE + sizeof(*fmt);
+
+ void *p __free(kfree) = kzalloc(pkt_size, GFP_KERNEL);
+ if (!p)
+ return -ENOMEM;
+
+ pkt = p;
+ fmt = p + APR_HDR_SIZE;
+ q6asm_add_hdr(ac, &pkt->hdr, pkt_size, true, stream_id);
+
+ pkt->hdr.opcode = ASM_DATA_CMD_MEDIA_FMT_UPDATE_V2;
+ fmt->fmt_blk.fmt_blk_size = sizeof(*fmt) - sizeof(fmt->fmt_blk);
+ fmt->num_channels = channels;
+ fmt->bits_per_sample = bits_per_sample;
+ fmt->sample_rate = rate;
+ fmt->is_signed = 1;
+ fmt->sample_word_size = sample_word_size;
+ fmt->endianness = ASM_PCM_ENDIAN_LITTLE;
+ fmt->mode = mode;
+
+ if (channel_map)
+ memcpy(fmt->channel_mapping, channel_map,
PCM_MAX_NUM_CHANNEL);
+ else if (q6dsp_map_channels(fmt->channel_mapping, channels))
+ return -EINVAL;
+
+ return q6asm_ac_send_cmd_sync(ac, pkt);
+}
+EXPORT_SYMBOL_GPL(q6asm_media_format_block_multi_ch_pcm_v4);
+
int q6asm_stream_media_format_block_flac(struct audio_client *ac,
uint32_t stream_id,
struct q6asm_flac_cfg *cfg)
@@ -1387,6 +1490,58 @@ int q6asm_enc_cfg_blk_pcm_format_support(struct
audio_client *ac,
}
EXPORT_SYMBOL_GPL(q6asm_enc_cfg_blk_pcm_format_support);
+/**
+ * q6asm_enc_cfg_blk_pcm_format_support_v4() - setup capture PCM
configuration (V4)
+ *
+ * @ac: audio client pointer
+ * @stream_id: stream id
+ * @rate: audio sample rate
+ * @channels: number of audio channels
+ * @bits_per_sample: valid bits per sample
+ * @sample_word_size: container size in bits
+ * @mode: Q factor / alignment selector (see V4 fmt_blk struct).
+ *
+ * Return: 0 on success, negative errno on failure.
+ */
+int q6asm_enc_cfg_blk_pcm_format_support_v4(struct audio_client *ac,
+ uint32_t stream_id, uint32_t
rate,
+ uint32_t channels,
+ uint16_t bits_per_sample,
+ uint16_t sample_word_size,
+ uint16_t mode)
+{
+ struct asm_multi_channel_pcm_enc_cfg_v4 *enc_cfg;
+ struct apr_pkt *pkt;
+ int pkt_size = APR_HDR_SIZE + sizeof(*enc_cfg);
+
+ void *p __free(kfree) = kzalloc(pkt_size, GFP_KERNEL);
+ if (!p)
+ return -ENOMEM;
+
+ pkt = p;
+ enc_cfg = p + APR_HDR_SIZE;
+ q6asm_add_hdr(ac, &pkt->hdr, pkt_size, true, stream_id);
+
+ pkt->hdr.opcode = ASM_STREAM_CMD_SET_ENCDEC_PARAM;
+ enc_cfg->encdec.param_id = ASM_PARAM_ID_ENCDEC_ENC_CFG_BLK_V2;
+ enc_cfg->encdec.param_size = sizeof(*enc_cfg) -
sizeof(enc_cfg->encdec);
+ enc_cfg->encblk.frames_per_buf = 0;
+ enc_cfg->encblk.enc_cfg_blk_size = enc_cfg->encdec.param_size -
+ sizeof(struct
asm_enc_cfg_blk_param_v2);
+ enc_cfg->num_channels = channels;
+ enc_cfg->bits_per_sample = bits_per_sample;
+ enc_cfg->sample_rate = rate;
+ enc_cfg->is_signed = 1;
+ enc_cfg->sample_word_size = sample_word_size;
+ enc_cfg->endianness = ASM_PCM_ENDIAN_LITTLE;
+ enc_cfg->mode = mode;
+
+ if (q6dsp_map_channels(enc_cfg->channel_mapping, channels))
+ return -EINVAL;
+
+ return q6asm_ac_send_cmd_sync(ac, pkt);
+}
+EXPORT_SYMBOL_GPL(q6asm_enc_cfg_blk_pcm_format_support_v4);
/**
* q6asm_read() - read data of period size from audio client
@@ -1471,7 +1626,7 @@ static int __q6asm_open_read(struct audio_client
*ac, uint32_t stream_id,
switch (format) {
case FORMAT_LINEAR_PCM:
open->mode_flags |= 0x00;
- open->enc_cfg_id = ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V2;
+ open->enc_cfg_id = ASM_MEDIA_FMT_MULTI_CHANNEL_PCM_V4;
break;
default:
pr_err("Invalid format[%d]\n", format);
diff --git a/sound/soc/qcom/qdsp6/q6asm.h b/sound/soc/qcom/qdsp6/q6asm.h
index 6fafda5bd849..36601a055381 100644
--- a/sound/soc/qcom/qdsp6/q6asm.h
+++ b/sound/soc/qcom/qdsp6/q6asm.h
@@ -107,6 +107,12 @@ int q6asm_enc_cfg_blk_pcm_format_support(struct
audio_client *ac,
uint32_t stream_id, uint32_t rate,
uint32_t channels,
uint16_t bits_per_sample);
+int q6asm_enc_cfg_blk_pcm_format_support_v4(struct audio_client *ac,
+ uint32_t stream_id, uint32_t
rate,
+ uint32_t channels,
+ uint16_t bits_per_sample,
+ uint16_t sample_word_size,
+ uint16_t mode);
int q6asm_read(struct audio_client *ac, uint32_t stream_id);
@@ -115,6 +121,14 @@ int q6asm_media_format_block_multi_ch_pcm(struct
audio_client *ac,
uint32_t rate, uint32_t channels,
u8
channel_map[PCM_MAX_NUM_CHANNEL],
uint16_t bits_per_sample);
+int q6asm_media_format_block_multi_ch_pcm_v4(struct audio_client *ac,
+ uint32_t stream_id,
+ uint32_t rate,
+ uint32_t channels,
+ u8
channel_map[PCM_MAX_NUM_CHANNEL],
+ uint16_t bits_per_sample,
+ uint16_t sample_word_size,
+ uint16_t mode);
int q6asm_stream_media_format_block_flac(struct audio_client *ac,
uint32_t stream_id,
struct q6asm_flac_cfg *cfg);
-------------------------------------->cut<--------------------------
>
> Changes in v2:
> - Cover playback as well as capture.
> - Remove the unused S24_LE case and update the backend comments.
> - Add Fixes and Reported-by, and document the raw-format change.
> - Rebase onto sound/for-next.
>
> v1: https://lore.kernel.org/179355993304.51321.11135059681945648585.q6asm-capture-format-v1@michaelmcallister.org/
>
> sound/soc/qcom/apq8096.c | 8 ++++++++
> sound/soc/qcom/qdsp6/q6asm-dai.c | 15 ++++++++++-----
> sound/soc/qcom/sc7180.c | 8 ++++++++
> 3 files changed, 26 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
> index cfd6438db..b7030f7ef 100644
> --- a/sound/soc/qcom/apq8096.c
> +++ b/sound/soc/qcom/apq8096.c
> @@ -6,6 +6,7 @@
> #include <sound/soc.h>
> #include <sound/soc-dapm.h>
> #include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> #include "common.h"
>
> #define SLIM_MAX_TX_PORTS 16
> @@ -19,10 +20,17 @@ static int apq8096_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
> SNDRV_PCM_HW_PARAM_RATE);
> struct snd_interval *channels = hw_param_interval(params,
> SNDRV_PCM_HW_PARAM_CHANNELS);
> + struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
>
> rate->min = rate->max = 48000;
> channels->min = channels->max = 2;
>
> + /* Keep the backend at 24 bits despite the 32-bit PCM container. */
> + if (params_format(params) == SNDRV_PCM_FORMAT_S32_LE) {
> + snd_mask_none(fmt);
> + snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S24_LE);
> + }
> +
> return 0;
> }
>
> diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
> index 4261c3048..cd97ba2ff 100644
> --- a/sound/soc/qcom/qdsp6/q6asm-dai.c
> +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
> @@ -90,7 +90,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_capture = {
> SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
> .formats = (SNDRV_PCM_FMTBIT_S16_LE |
> - SNDRV_PCM_FMTBIT_S24_LE),
> + SNDRV_PCM_FMTBIT_S32_LE),
> .rates = SNDRV_PCM_RATE_8000_48000,
> .rate_min = 8000,
> .rate_max = 48000,
> @@ -113,7 +113,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
> SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
> .formats = (SNDRV_PCM_FMTBIT_S16_LE |
> - SNDRV_PCM_FMTBIT_S24_LE),
> + SNDRV_PCM_FMTBIT_S32_LE),
> .rates = SNDRV_PCM_RATE_8000_192000,
> .rate_min = 8000,
> .rate_max = 192000,
> @@ -139,7 +139,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
> SNDRV_PCM_RATE_176400 | \
> SNDRV_PCM_RATE_192000), \
> .formats = (SNDRV_PCM_FMTBIT_S16_LE | \
> - SNDRV_PCM_FMTBIT_S24_LE), \
> + SNDRV_PCM_FMTBIT_S32_LE), \
> .channels_min = 1, \
> .channels_max = 8, \
> .rate_min = 8000, \
> @@ -151,7 +151,7 @@ static const struct snd_pcm_hardware q6asm_dai_hardware_playback = {
> SNDRV_PCM_RATE_12000 | \
> SNDRV_PCM_RATE_24000), \
> .formats = (SNDRV_PCM_FMTBIT_S16_LE | \
> - SNDRV_PCM_FMTBIT_S24_LE), \
> + SNDRV_PCM_FMTBIT_S32_LE), \
> .channels_min = 1, \
> .channels_max = 4, \
> .rate_min = 8000, \
> @@ -377,6 +377,11 @@ static int q6asm_dai_open(struct snd_soc_component *component,
>
> stream_id = cpu_dai->driver->id;
>
> + /* The DSP uses the high 24 bits of each 32-bit word. */
> + ret = snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
> + if (ret < 0)
> + return ret;
> +
> pdata = snd_soc_component_get_drvdata(component);
> if (!pdata) {
> dev_err(dev, "Drv data not found ..\n");
> @@ -505,7 +510,7 @@ static int q6asm_dai_hw_params(struct snd_soc_component *component,
> case SNDRV_PCM_FORMAT_S16_LE:
> prtd->bits_per_sample = 16;
> break;
> - case SNDRV_PCM_FORMAT_S24_LE:
> + case SNDRV_PCM_FORMAT_S32_LE:
> prtd->bits_per_sample = 24;
> break;
> }
> diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c
> index bc5a18883..dd0f8eb99 100644
> --- a/sound/soc/qcom/sc7180.c
> +++ b/sound/soc/qcom/sc7180.c
> @@ -13,6 +13,7 @@
> #include <sound/core.h>
> #include <sound/jack.h>
> #include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> #include <sound/soc.h>
> #include <uapi/linux/input-event-codes.h>
>
> @@ -425,10 +426,17 @@ static int sc7180_qdsp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
> SNDRV_PCM_HW_PARAM_RATE);
> struct snd_interval *channels = hw_param_interval(params,
> SNDRV_PCM_HW_PARAM_CHANNELS);
> + struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
>
> rate->min = rate->max = 48000;
> channels->min = channels->max = 2;
>
> + /* Keep the backend at 24 bits despite the 32-bit PCM container. */
> + if (params_format(params) == SNDRV_PCM_FORMAT_S32_LE) {
> + snd_mask_none(fmt);
> + snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S24_LE);
> + }
> +
> return 0;
> }
>
>
> base-commit: c937f492dd40a8398d955cf0f4f9e11d7268bcb5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format
2026-11-15 13:12 ` Srinivas Kandagatla
@ 2026-11-16 9:20 ` Demeter Barna
2026-11-16 15:02 ` Srinivas Kandagatla
0 siblings, 1 reply; 7+ messages in thread
From: Demeter Barna @ 2026-11-16 9:20 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Michael McAllister, Srinivas Kandagatla, Mark Brown, lgirdwood,
perex, tiwai, linux-sound, linux-arm-msm, linux-kernel
On 2026-11-15 13:12, Srinivas Kandagatla wrote:
> Can you please try this change and see if it helps. I have not tested
> this myself as am travelling atm.
Hi Srinivas,
Thanks, I gave it a go on SM8350.
The DSP takes the V4 blocks without complaining, but nothing changes for
me: S24_LE playback is still 48 dB down, same as without the patch. I
played a 440 Hz tone and recorded it with the DMICs:
without with
S16_LE -25 dBFS -25 dBFS
S24_LE (bits 23:0) -73 dBFS -73 dBFS
S24_LE, shifted into bits 31:8 -25 dBFS -25 dBFS
Capture is the same story, the samples still come back in bits 31:8.
Michael's v2 does work here, for what it's worth: S32_LE playback comes
out at -25 dBFS like S16_LE, and S32_LE capture records the tone at the
same level as S16_LE.
So it looks like this DSP just ignores mode 23. Maybe that depends on
the firmware version, but with the firmware this device ships it doesn't
work. If you have another way to fix this in mind, I'm happy to test it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format
2026-11-16 9:20 ` Demeter Barna
@ 2026-11-16 15:02 ` Srinivas Kandagatla
2026-11-16 16:49 ` Demeter Barna
0 siblings, 1 reply; 7+ messages in thread
From: Srinivas Kandagatla @ 2026-11-16 15:02 UTC (permalink / raw)
To: Demeter Barna
Cc: Michael McAllister, Srinivas Kandagatla, Mark Brown, lgirdwood,
perex, tiwai, linux-sound, linux-arm-msm, linux-kernel
On 11/16/26 9:20 AM, Demeter Barna wrote:
> On 2026-11-15 13:12, Srinivas Kandagatla wrote:
>> Can you please try this change and see if it helps. I have not tested
>> this myself as am travelling atm.
>
> Hi Srinivas,
>
> Thanks, I gave it a go on SM8350.
>
> The DSP takes the V4 blocks without complaining, but nothing changes for
> me: S24_LE playback is still 48 dB down, same as without the patch. I
> played a 440 Hz tone and recorded it with the DMICs:
>
> without with
> S16_LE -25 dBFS -25 dBFS
> S24_LE (bits 23:0) -73 dBFS -73 dBFS
> S24_LE, shifted into bits 31:8 -25 dBFS -25 dBFS
>
> Capture is the same story, the samples still come back in bits 31:8.
>
> Michael's v2 does work here, for what it's worth: S32_LE playback comes
> out at -25 dBFS like S16_LE, and S32_LE capture records the tone at the
> same level as S16_LE.
>
> So it looks like this DSP just ignores mode 23. Maybe that depends on
> the firmware version, but with the firmware this device ships it doesn't
> work. If you have another way to fix this in mind, I'm happy to test it.
Thanks Demeter,
If its easy, Could you try:
---
sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c
b/sound/soc/qcom/qdsp6/q6asm-dai.c
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -286,7 +286,7 @@ static int q6asm_dai_prepare(struct
snd_soc_component *component,
*/
if (prtd->bits_per_sample == 24) {
word_size = 32;
- mode = 23;
+ mode = 0; /* DEFAULT_QF: Q31 / MSB-aligned (bits 31:8) */
} else {
word_size = prtd->bits_per_sample;
mode = 0;
--
2.45.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format
2026-11-16 15:02 ` Srinivas Kandagatla
@ 2026-11-16 16:49 ` Demeter Barna
0 siblings, 0 replies; 7+ messages in thread
From: Demeter Barna @ 2026-11-16 16:49 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Michael McAllister, Srinivas Kandagatla, Mark Brown, lgirdwood,
perex, tiwai, linux-sound, linux-arm-msm, linux-kernel
On 2026-11-16 15:02, Srinivas Kandagatla wrote:
> If its easy, Could you try:
Tried it: mode 0 behaves the same as mode 23 and as without the patch.
S24_LE playback is still 48 dB below S16_LE (the same samples shifted
into bits 31:8 play at the S16_LE level), and S24_LE capture still
comes back in bits 31:8. So the mode doesn't seem to matter on this DSP.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-11-16 16:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-01 19:05 [PATCH] ASoC: qcom: q6asm: Correct the 24-bit capture format Michael McAllister
2026-11-04 20:47 ` Demeter Barna
2026-11-08 18:03 ` [PATCH v2] ASoC: qcom: q6asm: Correct the 24-bit PCM format Michael McAllister
2026-11-15 13:12 ` Srinivas Kandagatla
2026-11-16 9:20 ` Demeter Barna
2026-11-16 15:02 ` Srinivas Kandagatla
2026-11-16 16:49 ` Demeter Barna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®