mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drbd: Fix typo in comment
@ 2022-06-16 14:32 Xiang wangx
  2022-06-22 14:12 ` Christoph Böhmwalder
  0 siblings, 1 reply; 4+ messages in thread
From: Xiang wangx @ 2022-06-16 14:32 UTC (permalink / raw)
  To: axboe
  Cc: philipp.reisner, lars.ellenberg, christoph.boehmwalder, drbd-dev,
	linux-block, linux-kernel, Xiang wangx

Delete the redundant word 'and'.

Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
 drivers/block/drbd/drbd_bitmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c
index 9e060e49b3f8..8afdde400e37 100644
--- a/drivers/block/drbd/drbd_bitmap.c
+++ b/drivers/block/drbd/drbd_bitmap.c
@@ -86,7 +86,7 @@ struct drbd_bitmap {
 
 	/* exclusively to be used by __al_write_transaction(),
 	 * drbd_bm_mark_for_writeout() and
-	 * and drbd_bm_write_hinted() -> bm_rw() called from there.
+	 * drbd_bm_write_hinted() -> bm_rw() called from there.
 	 */
 	unsigned int n_bitmap_hints;
 	unsigned int al_bitmap_hints[AL_UPDATES_PER_TRANSACTION];
-- 
2.36.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drbd: Fix typo in comment
  2022-06-16 14:32 [PATCH] drbd: Fix typo in comment Xiang wangx
@ 2022-06-22 14:12 ` Christoph Böhmwalder
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Böhmwalder @ 2022-06-22 14:12 UTC (permalink / raw)
  To: Xiang wangx
  Cc: philipp.reisner, lars.ellenberg, drbd-dev, linux-block,
	linux-kernel, axboe

Am 16.06.22 um 16:32 schrieb Xiang wangx:
> Delete the redundant word 'and'.
> 
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
>  drivers/block/drbd/drbd_bitmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c
> index 9e060e49b3f8..8afdde400e37 100644
> --- a/drivers/block/drbd/drbd_bitmap.c
> +++ b/drivers/block/drbd/drbd_bitmap.c
> @@ -86,7 +86,7 @@ struct drbd_bitmap {
>  
>  	/* exclusively to be used by __al_write_transaction(),
>  	 * drbd_bm_mark_for_writeout() and
> -	 * and drbd_bm_write_hinted() -> bm_rw() called from there.
> +	 * drbd_bm_write_hinted() -> bm_rw() called from there.
>  	 */
>  	unsigned int n_bitmap_hints;
>  	unsigned int al_bitmap_hints[AL_UPDATES_PER_TRANSACTION];

Thanks!

Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>

-- 
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drbd: fix typo in comment
  2026-07-28  9:05 [PATCH] drbd: fix " Guo Tenglong
@ 2026-08-10 11:11 ` Christoph Böhmwalder
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Böhmwalder @ 2026-08-10 11:11 UTC (permalink / raw)
  To: Guo Tenglong, Philipp Reisner
  Cc: Lars Ellenberg, Jens Axboe, drbd-dev, linux-block, linux-kernel



Am 28.07.26 um 11:05 schrieb Guo Tenglong:
> Correct "seperate" to "separate" in a comment.
> 
> Signed-off-by: Guo Tenglong <micronull@163.com>
> ---
>  drivers/block/drbd/drbd_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c
> index adcba7f1d..98abd2351 100644
> --- a/drivers/block/drbd/drbd_state.c
> +++ b/drivers/block/drbd/drbd_state.c
> @@ -1339,7 +1339,7 @@ _drbd_set_state(struct drbd_device *device, union drbd_state ns,
>  
>  	remember_new_state(state_change);
>  
> -	/* put replicated vs not-replicated requests in seperate epochs */
> +	/* put replicated vs not-replicated requests in separate epochs */
>  	if (drbd_should_do_remote((union drbd_dev_state)os.i) !=
>  	    drbd_should_do_remote((union drbd_dev_state)ns.i))
>  		start_new_tl_epoch(connection);

Thanks for the patch.
Typo fixes like this are generally only worth it if they come with a
"real" fix in the same general reason. On their own, they just cause
more work for the maintainers involved with no real benefit --
especially in this case, where I initially struggled to even see the
difference.

NAK.

-- 
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drbd: fix typo in comment
@ 2026-07-28  9:05 Guo Tenglong
  2026-08-10 11:11 ` Christoph Böhmwalder
  0 siblings, 1 reply; 4+ messages in thread
From: Guo Tenglong @ 2026-07-28  9:05 UTC (permalink / raw)
  To: Philipp Reisner
  Cc: Lars Ellenberg, Christoph Böhmwalder, Jens Axboe, drbd-dev,
	linux-block, linux-kernel, Guo Tenglong

Correct "seperate" to "separate" in a comment.

Signed-off-by: Guo Tenglong <micronull@163.com>
---
 drivers/block/drbd/drbd_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c
index adcba7f1d..98abd2351 100644
--- a/drivers/block/drbd/drbd_state.c
+++ b/drivers/block/drbd/drbd_state.c
@@ -1339,7 +1339,7 @@ _drbd_set_state(struct drbd_device *device, union drbd_state ns,
 
 	remember_new_state(state_change);
 
-	/* put replicated vs not-replicated requests in seperate epochs */
+	/* put replicated vs not-replicated requests in separate epochs */
 	if (drbd_should_do_remote((union drbd_dev_state)os.i) !=
 	    drbd_should_do_remote((union drbd_dev_state)ns.i))
 		start_new_tl_epoch(connection);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-10 11:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 14:32 [PATCH] drbd: Fix typo in comment Xiang wangx
2022-06-22 14:12 ` Christoph Böhmwalder
2026-07-28  9:05 [PATCH] drbd: fix " Guo Tenglong
2026-08-10 11:11 ` Christoph Böhmwalder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®