* [PATCH -next] scsi: megasas: clean up some inconsistent indenting
@ 2022-02-24 0:47 Yang Li
2022-02-24 5:51 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-02-24 0:47 UTC (permalink / raw)
To: kashyap.desai
Cc: sumit.saxena, shivasharan.srikanteshwara, jejb, martin.petersen,
megaraidlinux.pdl, linux-scsi, linux-kernel, Yang Li,
Abaci Robot
Eliminate the follow smatch warning:
drivers/scsi/megaraid/megaraid_sas_fusion.c:5104 megasas_reset_fusion()
warn: inconsistent indenting
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index c72364864bf4..aab600ef4cd6 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -5101,8 +5101,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
memset(fusion->stream_detect_by_ld[j],
0, sizeof(struct LD_STREAM_DETECT));
- fusion->stream_detect_by_ld[j]->mru_bit_map
- = MR_STREAM_BITMAP;
+ fusion->stream_detect_by_ld[j]->mru_bit_map
+ = MR_STREAM_BITMAP;
}
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] scsi: megasas: clean up some inconsistent indenting
2022-02-24 0:47 [PATCH -next] scsi: megasas: clean up some inconsistent indenting Yang Li
@ 2022-02-24 5:51 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2022-02-24 5:51 UTC (permalink / raw)
To: Yang Li, kashyap.desai
Cc: sumit.saxena, shivasharan.srikanteshwara, jejb, martin.petersen,
megaraidlinux.pdl, linux-scsi, linux-kernel, Abaci Robot
On 2/24/22 09:47, Yang Li wrote:
> Eliminate the follow smatch warning:
> drivers/scsi/megaraid/megaraid_sas_fusion.c:5104 megasas_reset_fusion()
> warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index c72364864bf4..aab600ef4cd6 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -5101,8 +5101,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
> for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
> memset(fusion->stream_detect_by_ld[j],
> 0, sizeof(struct LD_STREAM_DETECT));
While at it, you could fix this weird indentation too.
> - fusion->stream_detect_by_ld[j]->mru_bit_map
> - = MR_STREAM_BITMAP;
> + fusion->stream_detect_by_ld[j]->mru_bit_map
> + = MR_STREAM_BITMAP;
Still inconsistent: missing one tab, no ?
> }
> }
Given the depth of the indentation, this initialization loop could go
into a little inline helper function.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-24 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 0:47 [PATCH -next] scsi: megasas: clean up some inconsistent indenting Yang Li
2022-02-24 5:51 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®