From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Waqar Hameed <waqar.hameed@axis.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
kernel@axis.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data
Date: Wed, 21 Oct 2026 15:53:11 +0200 [thread overview]
Message-ID: <b667b008-2d2c-4da8-8b1c-3b24b351ea64@oss.qualcomm.com> (raw)
In-Reply-To: <pndo6ctn350.a.out@axis.com>
On 10/16/26 4:14 PM, Waqar Hameed wrote:
> On Mon, Oct 12, 2026 at 17:52 +0200 Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>
>> On 10/2/26 12:36 AM, Waqar Hameed wrote:
>>> Multiple property data on a newline should be aligned with the first one
>>> or properly indented with tabs. Found/fixed with dtfmt (Devicetree
>>> Source formatter).
>>>
>>> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
>>> ---
[...]
> Which maybe is more clean than allowing the first string to overflow 100
> chars and aligning others to that one:
>
> clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore",
> "iface",
> "mem",
> "mem_iface";
>
> So the question is if we should either "try to fit within 100 chars, by
> adding newline after `=`" or "don't care about property data longer that
> 100 chars, always start first one after `=` on the same line". The
> latter one is of course much easier to implement :)
I have an ultrawide monitor so we can overflow waaay above 100 :D
But more seriously, between the low likelihood of this happening and
the presumed disadvantage of having to scroll sideways but still
being able to read without jumping to a different (line, col) with
your eyesight, letting super long properties overflow seems OK to
me.
Let's see if others agree
Konrad
next prev parent reply other threads:[~2026-10-21 13:53 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 22:36 [PATCH 00/38] arm: dts: qcom: Format with dtfmt Waqar Hameed
2026-10-01 22:36 ` [PATCH 02/38] arm: dts: qcom: pm8841: Remove superfluous empty lines Waqar Hameed
2026-10-12 15:21 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 01/38] arm: dts: qcom: pm8226: Add newline between subnodes Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 04/38] arm: dts: qcom: pm8941: Remove superfluous empty lines Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 03/38] arm: dts: qcom: pm8921: " Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 06/38] arm: dts: qcom: apq8026: Add newline between subnodes Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 05/38] arm: dts: qcom: pm8084: Remove superfluous empty line Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 07/38] arm: dts: qcom: apq8026: Add space between OR-operator Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 08/38] arm: dts: qcom: apq8060: Add newline between subnodes Waqar Hameed
2026-10-12 15:22 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 09/38] arm: dts: qcom: apq8060: Align multiple property data Waqar Hameed
2026-10-12 15:23 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 10/38] arm: dts: qcom: apq8060: Indent property data with tab Waqar Hameed
2026-10-12 15:24 ` Konrad Dybcio
2026-10-16 14:14 ` Waqar Hameed
2026-10-01 22:36 ` [PATCH 11/38] arm: dts: qcom: apq8064: Add newline between subnodes Waqar Hameed
2026-10-12 15:23 ` Konrad Dybcio
2026-10-16 14:14 ` Waqar Hameed
2026-10-01 22:36 ` [PATCH 12/38] arm: dts: qcom: apq8064: Remove empty line at end of node Waqar Hameed
2026-10-12 15:24 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 13/38] arm: dts: qcom: apq8064: Add space before line comments Waqar Hameed
2026-10-12 15:24 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data Waqar Hameed
2026-10-12 15:52 ` Konrad Dybcio
2026-10-16 14:14 ` Waqar Hameed
2026-10-21 13:53 ` Konrad Dybcio [this message]
2026-10-01 22:36 ` [PATCH 15/38] arm: dts: qcom: apq8064: Remove tab after property name Waqar Hameed
2026-10-12 15:24 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 16/38] arm: dts: qcom: ipq4018: Indent closing brace properly Waqar Hameed
2026-10-12 15:25 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 17/38] arm: dts: qcom: ipq4019: Add newline between subnodes Waqar Hameed
2026-10-12 15:25 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 19/38] arm: dts: qcom: ipq4019: Break long property array data Waqar Hameed
2026-10-12 15:26 ` Konrad Dybcio
2026-10-16 14:15 ` Waqar Hameed
2026-10-01 22:36 ` [PATCH 18/38] arm: dts: qcom: ipq4019: Align multiple property data Waqar Hameed
2026-10-12 15:26 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 21/38] arm: dts: qcom: ipq8064: " Waqar Hameed
2026-10-12 15:28 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 20/38] arm: dts: qcom: ipq8064: Add newline between subnodes Waqar Hameed
2026-10-12 15:28 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data Waqar Hameed
2026-10-12 15:31 ` Konrad Dybcio
2026-10-16 14:15 ` Waqar Hameed
2026-10-16 14:48 ` Krzysztof Kozlowski
2026-10-19 8:52 ` Waqar Hameed
2026-10-21 13:50 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 23/38] arm: dts: qcom: msm8226: Add space between OR-operator Waqar Hameed
2026-10-12 15:28 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 25/38] arm: dts: qcom: ipq8064: Break long property array data Waqar Hameed
2026-10-01 22:36 ` [PATCH 24/38] arm: dts: qcom: msm8226: Add newline between subnodes Waqar Hameed
2026-10-12 15:28 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 26/38] arm: dts: qcom: msm8226: Align multiple property data Waqar Hameed
2026-10-12 15:31 ` Konrad Dybcio
2026-10-16 14:15 ` Waqar Hameed
2026-10-01 22:36 ` [PATCH 27/38] arm: dts: qcom: msm8660: Remove empty line at end of node Waqar Hameed
2026-10-12 15:31 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 28/38] arm: dts: qcom: msm8660: Remove space inside array property Waqar Hameed
2026-10-12 15:31 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 29/38] arm: dts: qcom: msm8660: Align closing array bracket Waqar Hameed
2026-10-12 15:31 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 30/38] arm: dts: qcom: msm8916: Add newline between subnodes Waqar Hameed
2026-10-12 15:31 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 31/38] arm: dts: qcom: msm8960: Properly indent subnodes Waqar Hameed
2026-10-12 15:50 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 32/38] arm: dts: qcom: msm8660: Align closing array bracket Waqar Hameed
2026-10-12 15:50 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 33/38] arm: dts: qcom: msm8974: Align multiple property data Waqar Hameed
2026-10-12 15:51 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 34/38] arm: dts: qcom: msm8974: Align closing brace properly Waqar Hameed
2026-10-12 15:51 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 35/38] arm: dts: qcom: msm8974: Add newline between subnodes Waqar Hameed
2026-10-12 15:51 ` Konrad Dybcio
2026-10-16 14:15 ` Waqar Hameed
2026-10-16 14:44 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 37/38] arm: dts: qcom: sdx65: Remove empty line at end of node Waqar Hameed
2026-10-12 15:51 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 36/38] arm: dts: qcom: sdx55: Properly indent subnode Waqar Hameed
2026-10-12 15:51 ` Konrad Dybcio
2026-10-01 22:36 ` [PATCH 38/38] arm: dts: qcom: sdx65: Align multiple property data Waqar Hameed
2026-10-12 15:52 ` Konrad Dybcio
2026-10-12 15:28 ` [PATCH 00/38] arm: dts: qcom: Format with dtfmt Konrad Dybcio
2026-10-16 14:13 ` Waqar Hameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b667b008-2d2c-4da8-8b1c-3b24b351ea64@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®