Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

[Govinda Tatti <govinda.tatti@oracle.com>]

Thanks Konrad for your response. Please see below for my comments.

>>>> Well, that's more a question to Konrad as the maintainer.
>>>> Personally I'd prefer just "reset", as "pci" is redundant and "bus"
>>> Can't do 'reset'.
>> Why?
> B/c I forgot that this attribute is not per device, but on the module sub-directory:
>
> /sys/bus/pci/drivers/pciback/do_flr
>
> It can be indeed called 'reset'.

Good.  We will rename sysfs attribute from "do_flr" to "reset"

>>>> doesn't cover the slot variant.
>>> 'bus_reset' sounds lovely?
>> Lovely sounding or not, it may end up misleading, and even more so
>> if - like asked for - FLR would be tried first.
> Fair enough. Reset should work then.
So, we will use the following sequence to reset the requested 
device/function.

- FLR (as first option)
- BUS/SLOT reset (as fall-back option) if FLR is not supported or any 
issue with FLR

Cheers
GOVINDA