From: Govinda Tatti <govinda.tatti@oracle.com>
To: "Juergen Gross" <jgross@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
linux-kernel@vger.kernel.org, konrad.wilk@oracle.com
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute
Date: Wed, 8 Nov 2017 09:34:54 -0600 [thread overview]
Message-ID: <aca6237f-f430-a06d-e4b1-9a11661f3502@oracle.com> (raw)
In-Reply-To: <54bdfc56-891f-5c78-77c1-29758f8220f4@suse.com>
On 11/8/2017 9:09 AM, Juergen Gross wrote:
> On 08/11/17 16:00, Govinda Tatti wrote:
>> Thanks Roger for your review comments. Please see below for my comments.
>>
>> On 11/7/2017 5:21 AM, Roger Pau Monné wrote:
>>> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote:
>>>> +out:
>>>> + if (!err)
>>>> + err = count;
>>>> +
>>>> + return err;
>>> What's the purpose of returning count here?
>> Not sure. Will check with Konrad and address this comment.
> You are telling sysfs that you have consumed all input characters.
>
Thanks Juergen
Cheers
GOVINDA
next prev parent reply other threads:[~2017-11-08 15:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 17:48 Govinda Tatti
2017-11-07 11:21 ` [Xen-devel] " Roger Pau Monné
2017-11-08 15:00 ` Govinda Tatti
2017-11-08 15:09 ` Juergen Gross
2017-11-08 15:34 ` Govinda Tatti [this message]
2017-11-07 14:40 ` Jan Beulich
2017-11-08 15:44 ` Govinda Tatti
2017-11-08 17:38 ` Pasi Kärkkäinen
2017-11-08 23:26 ` Govinda Tatti
2017-11-09 8:28 ` Jan Beulich
2017-11-29 15:08 ` Govinda Tatti
2017-11-29 15:35 ` Jan Beulich
2017-11-29 16:29 ` Konrad Rzeszutek Wilk
2017-11-29 16:40 ` Jan Beulich
2017-11-29 19:26 ` Konrad Rzeszutek Wilk
2017-11-29 19:44 ` Govinda Tatti
2017-11-30 8:29 ` Jan Beulich
2017-11-30 13:55 ` Govinda Tatti
2017-11-29 17:25 ` Govinda Tatti
2017-11-29 18:05 ` Pasi Kärkkäinen
2017-11-29 19:51 ` Govinda Tatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aca6237f-f430-a06d-e4b1-9a11661f3502@oracle.com \
--to=govinda.tatti@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®