From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"hare@suse.de" <hare@suse.de>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alistair Francis <alistair.francis@wdc.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/3] nvme: Allow reauth from sysfs
Date: Mon, 3 Nov 2025 02:05:55 +0000 [thread overview]
Message-ID: <b684812e-8ade-4adc-aa08-2e4fcc9811d7@nvidia.com> (raw)
In-Reply-To: <CAKmqyKNr8N4r=9RvgErr-zj929gd8oRfdKGgrhVajK_UxR828g@mail.gmail.com>
On 11/2/25 5:47 PM, Alistair Francis wrote:
> On Sat, Nov 1, 2025 at 12:05 AM Christoph Hellwig<hch@lst.de> wrote:
>> On Thu, Oct 30, 2025 at 01:51:14PM +1000,alistair23@gmail.com wrote:
>>> From: Alistair Francis<alistair.francis@wdc.com>
>>>
>>> Allow userspace to trigger a reauth (REPLACETLSPSK) from sysfs.
>>> This can be done by writing the queue ID to te sysfs file.
>>>
>>> echo 0 > /sys/devices/virtual/nvme-fabrics/ctl/nvme0/replace_psk
>>>
>>> Note that only QID 0 (admin queue) is supported.
>> Why pass the queue ID then instead of a boolean value?
> I liked the explicitness of passing a queue ID instead of a bool and
> it allows supporting more queues in the future if that changes in the
> spec.
>
> I can change it to a bool instead if that's preferred?
>
> Alistair
do you have any plans to add support for the I/O queues in future ?
OR
have a strong usecase for I/O queues to support this feature ?
-ck
next prev parent reply other threads:[~2025-11-03 2:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 3:51 [PATCH 0/3] nvme: Support PSK reauthentication (REPLACETLSPSK) alistair23
2025-10-30 3:51 ` [PATCH 1/3] nvmet-tcp: Don't error if TLS is enabed on a reset alistair23
2025-10-31 10:03 ` Christoph Hellwig
2025-10-30 3:51 ` [PATCH 2/3] nvmet-tcp: Don't free SQ on authentication success alistair23
2025-10-31 14:03 ` Christoph Hellwig
2025-11-03 1:40 ` Alistair Francis
2025-10-30 3:51 ` [PATCH 3/3] nvme: Allow reauth from sysfs alistair23
2025-10-31 14:05 ` Christoph Hellwig
2025-11-03 1:47 ` Alistair Francis
2025-11-03 2:05 ` Chaitanya Kulkarni [this message]
2025-11-03 2:24 ` Alistair Francis
2025-11-03 2:32 ` Chaitanya Kulkarni
2025-11-03 11:58 ` Christoph Hellwig
2025-11-03 12:08 ` Hannes Reinecke
2025-11-11 23:32 ` Alistair Francis
2025-11-12 7:02 ` Christoph Hellwig
2025-11-12 7:21 ` Hannes Reinecke
2025-11-12 8:32 ` Christoph Hellwig
2025-11-13 4:01 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b684812e-8ade-4adc-aa08-2e4fcc9811d7@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®