Re: [PATCH 3/3] nvme: Allow reauth from sysfs

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 11/2/25 6:24 PM, Alistair Francis wrote:
> On Mon, Nov 3, 2025 at 12:05 PM Chaitanya Kulkarni
> <chaitanyak@nvidia.com> wrote:
>> On 11/2/25 5:47 PM, Alistair Francis wrote:
>>> On Sat, Nov 1, 2025 at 12:05 AM Christoph Hellwig<hch@lst.de> wrote:
>>>> On Thu, Oct 30, 2025 at 01:51:14PM +1000,alistair23@gmail.com wrote:
>>>>> From: Alistair Francis<alistair.francis@wdc.com>
>>>>>
>>>>> Allow userspace to trigger a reauth (REPLACETLSPSK) from sysfs.
>>>>> This can be done by writing the queue ID to te sysfs file.
>>>>>
>>>>> echo 0 > /sys/devices/virtual/nvme-fabrics/ctl/nvme0/replace_psk
>>>>>
>>>>> Note that only QID 0 (admin queue) is supported.
>>>> Why pass the queue ID then instead of a boolean value?
>>> I liked the explicitness of passing a queue ID instead of a bool and
>>> it allows supporting more queues in the future if that changes in the
>>> spec.
>>>
>>> I can change it to a bool instead if that's preferred?
>>>
>>> Alistair
>> do you have any plans to add support for the I/O queues in future ?
> No, it would require a spec change


okay so it's going to be significant change of functionality via spec.


>> OR
>> have a strong usecase for I/O queues to support this feature ?
> I do not, but it does seem like something that maybe should be supported


it does sound useful and it's a spac change so how about we add separate 
I/O queues interface with spec change and keep this purely admin queue ?

> Alistair
>
>> -ck
>>