* Re: [PATCH] PM / devfreq: tegra: add COMMON_CLK dependency
2019-12-11 12:54 ` [PATCH] PM / devfreq: tegra: add COMMON_CLK dependency Arnd Bergmann
@ 2019-12-11 14:44 ` Dmitry Osipenko
2019-12-12 2:58 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2019-12-11 14:44 UTC (permalink / raw)
To: Arnd Bergmann, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
Geert Uytterhoeven
Cc: Thomas Gleixner, linux-pm, linux-kernel
11.12.2019 15:54, Arnd Bergmann пишет:
> Compile-testing this driver fails if CONFIG_COMMON_CLK is not set:
>
> drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> tegra30-devfreq.c:(.text+0x164): undefined reference to `clk_set_min_rate'
>
> Fixes: 35f8dbc72721 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/devfreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index defe1d438710..f712c3de0876 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -98,6 +98,7 @@ config ARM_TEGRA_DEVFREQ
> ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
> ARCH_TEGRA_210_SOC || \
> COMPILE_TEST
> + depends on COMMON_CLK
> select PM_OPP
> help
> This adds the DEVFREQ driver for the Tegra family of SoCs.
>
Hello Arnd,
I was about to send the same change because Geert Uytterhoeven reported
the problem a day ago [1], but you beat me to it.
[1] https://www.spinics.net/lists/linux-tegra/msg46169.html
Thank you very much for the patch!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PM / devfreq: tegra: add COMMON_CLK dependency
2019-12-11 12:54 ` [PATCH] PM / devfreq: tegra: add COMMON_CLK dependency Arnd Bergmann
2019-12-11 14:44 ` Dmitry Osipenko
@ 2019-12-12 2:58 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2019-12-12 2:58 UTC (permalink / raw)
To: Arnd Bergmann, MyungJoo Ham, Kyungmin Park, Dmitry Osipenko
Cc: Thomas Gleixner, linux-pm, linux-kernel
On 12/11/19 9:54 PM, Arnd Bergmann wrote:
> Compile-testing this driver fails if CONFIG_COMMON_CLK is not set:
>
> drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> tegra30-devfreq.c:(.text+0x164): undefined reference to `clk_set_min_rate'
>
> Fixes: 35f8dbc72721 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/devfreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index defe1d438710..f712c3de0876 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -98,6 +98,7 @@ config ARM_TEGRA_DEVFREQ
> ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
> ARCH_TEGRA_210_SOC || \
> COMPILE_TEST
> + depends on COMMON_CLK
> select PM_OPP
> help
> This adds the DEVFREQ driver for the Tegra family of SoCs.
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread