[PATCH v2] drm/radeon: convert VCE logging to drm_* helpers

[PATCH v2] drm/radeon: convert VCE logging to drm_* helpers

[Mukesh Ogare]

Replace legacy DRM_ERROR() and DRM_INFO() logging in the VCE code
with drm_err() and drm_info() helpers that take a struct drm_device.

Using drm_* logging provides proper device context in dmesg, which is
important for systems with multiple DRM devices, and aligns the radeon
driver with current DRM logging practices.

No functional change intended.

Signed-off-by: Mukesh Ogare <mukeshogare871@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
index a203992cb932..fd176034b251 100644
--- a/drivers/gpu/drm/radeon/radeon_vce.c
+++ b/drivers/gpu/drm/radeon/radeon_vce.c
@@ -121,7 +121,7 @@ int radeon_vce_init(struct radeon_device *rdev)
 	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
 		return -EINVAL;
 
-	drm_err(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
+	drm_info(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
 		 start, mid, end, rdev->vce.fb_version);
 
 	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
-- 
2.43.0

Re: [PATCH v2] drm/radeon: convert VCE logging to drm_* helpers

[Christian König]

On 12/20/25 09:01, Mukesh Ogare wrote:
> Replace legacy DRM_ERROR() and DRM_INFO() logging in the VCE code
> with drm_err() and drm_info() helpers that take a struct drm_device.
> 
> Using drm_* logging provides proper device context in dmesg, which is
> important for systems with multiple DRM devices, and aligns the radeon
> driver with current DRM logging practices.
> 
> No functional change intended.

I agree that this should only be info level, but you turn an error level into an info level, so that is a functional change.

Please adjust the commit message accordingly.

Regards,
Christian.

> 
> Signed-off-by: Mukesh Ogare <mukeshogare871@gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
> index a203992cb932..fd176034b251 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -121,7 +121,7 @@ int radeon_vce_init(struct radeon_device *rdev)
>  	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
>  		return -EINVAL;
>  
> -	drm_err(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
> +	drm_info(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
>  		 start, mid, end, rdev->vce.fb_version);
>  
>  	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);

[PATCH] drm/radeon: convert VCE logging to drm_* helpers

[Mukesh Ogare]

Replace legacy DRM_INFO() logging in the VCE code with drm_info()
helper that takes a struct drm_device.

This provides proper device context in dmesg on multi-GPU systems and
aligns the radeon driver with current DRM logging practices.

Note that this change logs firmware version information at info level
and does not indicate a failure.

Signed-off-by: Mukesh Ogare <mukeshogare871@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_vce.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
index bdbc1bbe8a9b..ed631c0e5e28 100644
--- a/drivers/gpu/drm/radeon/radeon_vce.c
+++ b/drivers/gpu/drm/radeon/radeon_vce.c
@@ -121,8 +121,9 @@ int radeon_vce_init(struct radeon_device *rdev)
 	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
 		return -EINVAL;
 
-	DRM_INFO("Found VCE firmware/feedback version %d.%d.%d / %d!\n",
-		 start, mid, end, rdev->vce.fb_version);
+	drm_info(&rdev->ddev,
+			"Found VCE firmware/feedback version %d.%d.%d / %d!\n",
+			start, mid, end, rdev->vce.fb_version);
 
 	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
 
-- 
2.43.0

Re: [PATCH] drm/radeon: convert VCE logging to drm_* helpers

[Alex Deucher]

Applied.  Thanks!

On Tue, Jan 20, 2026 at 3:26 AM Mukesh Ogare <mukeshogare871@gmail.com> wrote:
>
> Replace legacy DRM_INFO() logging in the VCE code with drm_info()
> helper that takes a struct drm_device.
>
> This provides proper device context in dmesg on multi-GPU systems and
> aligns the radeon driver with current DRM logging practices.
>
> Note that this change logs firmware version information at info level
> and does not indicate a failure.
>
> Signed-off-by: Mukesh Ogare <mukeshogare871@gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_vce.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
> index bdbc1bbe8a9b..ed631c0e5e28 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -121,8 +121,9 @@ int radeon_vce_init(struct radeon_device *rdev)
>         if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
>                 return -EINVAL;
>
> -       DRM_INFO("Found VCE firmware/feedback version %d.%d.%d / %d!\n",
> -                start, mid, end, rdev->vce.fb_version);
> +       drm_info(&rdev->ddev,
> +                       "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
> +                       start, mid, end, rdev->vce.fb_version);
>
>         rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
>
> --
> 2.43.0
>