mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: alps: Simplify the .remove function
Date: Mon, 3 Oct 2022 21:16:55 +0200	[thread overview]
Message-ID: <b6c0cda1-b30d-5ca9-54e5-0643f7d5ffd9@wanadoo.fr> (raw)
In-Reply-To: <YzsCdyPxrNcHE3XF@gmail.com>

Le 03/10/2022 à 17:40, Marcus Folkesson a écrit :
> Hi Christophe!
> 
> On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote:
>> If the .remove function of a 'hid_driver' is NULL, the default behavior is
>> to call hid_hw_stop().
>>
>> So alps_remove() can be removed here, it is just hand-writing what
>> already exists.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
> 
> 
> There is already a patch out there :-)

Great,

But I always find it funny when something that is there since many years 
(819d64e51d62 - 2016-06-23) is fixed twice in a row from unrelated work!

CJ

> 
> https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@gmail.com/
> 
> Best regards,
> Marcus Folkesson


      reply	other threads:[~2022-10-03 19:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 14:38 Christophe JAILLET
2022-10-03 15:40 ` Marcus Folkesson
2022-10-03 19:16   ` Christophe JAILLET [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6c0cda1-b30d-5ca9-54e5-0643f7d5ffd9@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus.folkesson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®