Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded check list

[David Hildenbrand <david@redhat.com>]

On 15.06.23 17:04, Ruhl, Michael J wrote:
>> -----Original Message-----
>> From: Joe Perches <joe@perches.com>
>> Sent: Wednesday, June 14, 2023 9:47 PM
>> To: Ruhl, Michael J <michael.j.ruhl@intel.com>; linux-kernel@vger.kernel.org;
>> apw@canonical.com; dwaipayanray1@gmail.com; lukas.bulwahn@gmail.com;
>> corbet@lwn.net; david@redhat.com
>> Subject: Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the
>> excluded check list
>>
>> On Wed, 2023-06-14 at 12:49 -0400, Michael J. Ruhl wrote:
>>> GEM_BUG_ON is usually compiled as WARN.  You have to change to
>>> debug configuration to get this to be BUG.
>>>
>>> checkpatch flags this a WARN level issue.
>>>
>>> Since this is a i915 local debug macro, allow its use in checkpatch.pl.
>>>
>>> Fixes: 69d517e6e210 ("checkpatch: warn on usage of VM_BUG_ON() and
>> other BUG variants")
>>
>> Not a "Fixes", just an additional check
> 

That was discussed when developing that patch:

https://lore.kernel.org/linux-mm/87tu5vflld.fsf@intel.com/T/

GEM_BUG_ON(
-> Bad with CONFIG_DRM_I915_DEBUG_GEM_ONCE

Just like VM_BUG_ON or CI_BUG_ON... that BUGs only with another kernel 
config on.

So this is expected.

-- 
Cheers,

David / dhildenb