From: Joe Perches <joe@perches.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>,
linux-kernel@vger.kernel.org, apw@canonical.com,
dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, corbet@lwn.net,
david@redhat.com
Subject: Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded check list
Date: Wed, 14 Jun 2023 18:47:26 -0700 [thread overview]
Message-ID: <b777a049b3817c7eee364310aac89470e9ea882e.camel@perches.com> (raw)
In-Reply-To: <20230614164955.1319870-1-michael.j.ruhl@intel.com>
On Wed, 2023-06-14 at 12:49 -0400, Michael J. Ruhl wrote:
> GEM_BUG_ON is usually compiled as WARN. You have to change to
> debug configuration to get this to be BUG.
>
> checkpatch flags this a WARN level issue.
>
> Since this is a i915 local debug macro, allow its use in checkpatch.pl.
>
> Fixes: 69d517e6e210 ("checkpatch: warn on usage of VM_BUG_ON() and other BUG variants")
Not a "Fixes", just an additional check
>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b30114d637c4..d3ddde4cd63e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4821,7 +4821,7 @@ sub process {
> }
>
> # do not use BUG() or variants
> - if ($line =~ /\b(?!AA_|BUILD_|DCCP_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
> + if ($line =~ /\b(?!AA_|BUILD_|DCCP_|GEM_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
> my $msg_level = \&WARN;
> $msg_level = \&CHK if ($file);
> &{$msg_level}("AVOID_BUG",
next prev parent reply other threads:[~2023-06-15 1:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 16:49 Michael J. Ruhl
2023-06-15 1:47 ` Joe Perches [this message]
2023-06-15 15:04 ` Ruhl, Michael J
2023-06-15 15:28 ` David Hildenbrand
2023-06-15 19:23 ` Ruhl, Michael J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b777a049b3817c7eee364310aac89470e9ea882e.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=michael.j.ruhl@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®