From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Judith Mendez <jm@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
David Lechner <david@lechnology.com>, Nishanth Menon <nm@ti.com>,
William Breathitt Gray <wbg@kernel.org>
Subject: Re: [PATCH v4 1/8] dt-bindings: counter: Add new ti,am62-eqep compatible
Date: Tue, 11 Jun 2024 08:51:47 +0200 [thread overview]
Message-ID: <b72164f9-1b1b-4329-8d4a-66fc626c45fe@linaro.org> (raw)
In-Reply-To: <01433df1-aa19-4abb-9d87-c54e4c0dff17@ti.com>
On 11/06/2024 00:13, Judith Mendez wrote:
>
> Hi Krzysztof,
>
> On 6/10/24 9:58 AM, Krzysztof Kozlowski wrote:
>> On 10/06/2024 16:46, Judith Mendez wrote:
>>> Add new compatible ti,am62-eqep for TI K3 devices. If a device
>>> uses this compatible, require power-domains property.
>>>
>>> Since there is only one functional and interface clock for eqep,
>>> clock-names is not really required, so removed from required
>>> section, make it optional for ti,am3352-eqep compatible, and
>>> update the example.
>>>
>>
>> ...
>>
>>
>>> interrupts = <79>;
>>> };
>>>
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/irq.h>
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
>>> +
>>> + bus {
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> + eqep1: counter@23210000 {
>>
>> No need for label
>>
>>> + compatible = "ti,am62-eqep";
>>> + reg = <0x00 0x23210000 0x00 0x100>;
>>> + power-domains = <&k3_pds 60 TI_SCI_PD_EXCLUSIVE>;
>>> + clocks = <&k3_clks 60 0>;
>>> + interrupts = <GIC_SPI 117 IRQ_TYPE_EDGE_RISING>;
>>> + status = "disabled";
>>
>> Drop... which also points to another comment - since this was no-op and
>> example is basically the same, then just don't add it. No point.
>
> Ok, then I will drop the new example, thanks.
>
> BTW..
> In the existing example for ti,am3352-eqep compatible,
> do you know if it is appropriate to drop clock-names
> from the example if it is no longer required?
>
It does not really matter.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-11 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 14:46 [PATCH v4 0/8] Enable eQEP DT support for Sitara K3 platforms Judith Mendez
2024-06-10 14:46 ` [PATCH v4 1/8] dt-bindings: counter: Add new ti,am62-eqep compatible Judith Mendez
2024-06-10 14:58 ` Krzysztof Kozlowski
2024-06-10 22:13 ` Judith Mendez
2024-06-11 6:51 ` Krzysztof Kozlowski [this message]
2024-06-11 13:52 ` Judith Mendez
2024-06-10 14:46 ` [PATCH v4 2/8] counter/ti-eqep: Add new ti-am62-eqep compatible Judith Mendez
2024-06-10 14:46 ` [PATCH v4 3/8] arm64: dts: ti: k3-am62-main: Add eQEP nodes Judith Mendez
2024-06-10 14:46 ` [PATCH v4 4/8] arm64: dts: ti: k3-am62a-main: " Judith Mendez
2024-06-10 14:46 ` [PATCH v4 5/8] arm64: dts: ti: k3-am62p-main: " Judith Mendez
2024-06-10 14:46 ` [PATCH v4 6/8] arm64: dts: ti: k3-am64-main: " Judith Mendez
2024-06-10 14:46 ` [PATCH v4 7/8] arm64: dts: ti: k3-am64x-sk: Enable eQEP Judith Mendez
2024-06-10 14:46 ` [PATCH v4 8/8] counter: ti-eqep: Allow eQEP driver to be built for K3 devices Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b72164f9-1b1b-4329-8d4a-66fc626c45fe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®