From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
aiqun.yu@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com,
yijie.yang@oss.qualcomm.com, jingyi.wang@oss.qualcomm.com
Subject: Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
Date: Wed, 7 Jan 2026 09:20:13 +0100 [thread overview]
Message-ID: <b724795f-1a76-4cc2-9417-2e4dd7dc7305@kernel.org> (raw)
In-Reply-To: <f6ca8c43-9f00-4dd8-9e11-90f2a4e8d18e@oss.qualcomm.com>
On 22/12/2025 14:06, Jishnu Prakash wrote:
> Hi Krzysztof,
>
> On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote:
>> On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
>>> Add support for PMH0101 PWM modules which are compatible with the PM8350c
>>> PWM modules.
>>>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>>> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>>> ---
>>> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> So how many nvmem entries it has? You need to define it in schema.
>>
>
> PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that
> PM8550 PWM was earlier added under the "if:then" condition for the number
> of nvmem entries and you made this change which removed that line:
Right, code is fine.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-07 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 11:11 [PATCH v3 0/2] dt-bindings: leds: Add bindings for Kaanapali PMIC peripherals Jishnu Prakash
2025-12-15 11:11 ` [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM Jishnu Prakash
2025-12-17 8:15 ` Krzysztof Kozlowski
2025-12-22 13:06 ` Jishnu Prakash
2026-01-07 8:20 ` Krzysztof Kozlowski [this message]
2026-01-20 16:11 ` (subset) " Lee Jones
2025-12-15 11:11 ` [PATCH v3 2/2] dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible Jishnu Prakash
2025-12-17 8:15 ` Krzysztof Kozlowski
2026-01-13 12:00 ` [PATCH v3 0/2] dt-bindings: leds: Add bindings for Kaanapali PMIC peripherals Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b724795f-1a76-4cc2-9417-2e4dd7dc7305@kernel.org \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=robh@kernel.org \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®