[PATCH v3 0/2] dt-bindings: leds: Add bindings for Kaanapali PMIC peripherals

[PATCH v3 0/2] dt-bindings: leds: Add bindings for Kaanapali PMIC peripherals

[Jishnu Prakash]

Add bindings for flash led and PWM devices present on Kaanapali PMICs.

Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
---
Changes in v3:
- Rebased patches to Linux 6.19-rc1.
- Link to v2: https://lore.kernel.org/r/20250924-knp-pmic-peri-v2-0-32316039db2f@oss.qualcomm.com

Changes in v2:
- Link to v1: https://lore.kernel.org/r/20250924-knp-pmic-peri-v1-0-47413f8ddbf2@oss.qualcomm.com

---
Jishnu Prakash (2):
      dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
      dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible

 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml       | 1 +
 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251215-knp-pmic-leds-867d616322c6

Best regards,
-- 
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

[PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

[Jishnu Prakash]

Add support for PMH0101 PWM modules which are compatible with the PM8350c
PWM modules.

Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index c4b7e57b2518..3da0fe532e74 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -43,6 +43,7 @@ properties:
       - items:
           - enum:
               - qcom,pm8550-pwm
+              - qcom,pmh0101-pwm
           - const: qcom,pm8350c-pwm
       - items:
           - enum:

-- 
2.25.1

Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

[Krzysztof Kozlowski]

On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
> Add support for PMH0101 PWM modules which are compatible with the PM8350c
> PWM modules.
> 
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>  1 file changed, 1 insertion(+)

So how many nvmem entries it has? You need to define it in schema.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

[Jishnu Prakash]

Hi Krzysztof,

On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote:
> On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
>> Add support for PMH0101 PWM modules which are compatible with the PM8350c
>> PWM modules.
>>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> So how many nvmem entries it has? You need to define it in schema.
> 

PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that
PM8550 PWM was earlier added under the "if:then" condition for the number
of nvmem entries and you made this change which removed that line:

https://lore.kernel.org/all/20240226073713.19045-1-krzysztof.kozlowski@linaro.org/

    dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:

    "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
    fallback), thus it is enough for the "if:then:" clause to check for the
    presence of the fallback "qcom,pm8350c-pwm".

PMH0101 PWM would be the same as it also has PM8350C PWM as fallback.
Do you prefer that I add it or not?

Thanks,
Jishnu


> Best regards,
> Krzysztof
> 

Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

[Krzysztof Kozlowski]

On 22/12/2025 14:06, Jishnu Prakash wrote:
> Hi Krzysztof,
> 
> On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote:
>> On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
>>> Add support for PMH0101 PWM modules which are compatible with the PM8350c
>>> PWM modules.
>>>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>>> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>>> ---
>>>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> So how many nvmem entries it has? You need to define it in schema.
>>
> 
> PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that
> PM8550 PWM was earlier added under the "if:then" condition for the number
> of nvmem entries and you made this change which removed that line:

Right, code is fine.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: (subset) [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

[Lee Jones]

On Mon, 15 Dec 2025 16:41:04 +0530, Jishnu Prakash wrote:
> Add support for PMH0101 PWM modules which are compatible with the PM8350c
> PWM modules.
> 
> 

Applied, thanks!

[1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
      commit: f23ead3e84085cb6119ff07584b9e30a89ee30c4

--
Lee Jones [李琼斯]

[PATCH v3 2/2] dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible

[Jishnu Prakash]

Document compatible for PMH0101 Torch and Flash LED controller.

Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
index 05250aefd385..3bfa24ff58cd 100644
--- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
+++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
@@ -29,6 +29,7 @@ properties:
           - qcom,pm8150l-flash-led
           - qcom,pm8350c-flash-led
           - qcom,pm8550-flash-led
+          - qcom,pmh0101-flash-led
           - qcom,pmi8998-flash-led
       - const: qcom,spmi-flash-led
 

-- 
2.25.1

Re: [PATCH v3 2/2] dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible

[Krzysztof Kozlowski]

On Mon, Dec 15, 2025 at 04:41:05PM +0530, Jishnu Prakash wrote:
> Document compatible for PMH0101 Torch and Flash LED controller.
> 
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH v3 0/2] dt-bindings: leds: Add bindings for Kaanapali PMIC peripherals

[Lee Jones]

On Mon, 15 Dec 2025 16:41:03 +0530, Jishnu Prakash wrote:
> Add bindings for flash led and PWM devices present on Kaanapali PMICs.
> 
> 

Applied, thanks!

[1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
      commit: b0235d5724851d223d347b16630b6db304a1b15d
[2/2] dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible
      commit: a19ae77cf3c71379188b71aacdc3ed906f84f22b

--
Lee Jones [李琼斯]