mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rick Lindsley <ricklind@linux.vnet.ibm.com>
To: David Hildenbrand <david@redhat.com>,
	Scott Cheloha <cheloha@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: nathanl@linux.ibm.com
Subject: Re: [PATCH] drivers/base/memory.c: memory subsys init: skip search for missing blocks
Date: Fri, 1 Nov 2019 15:32:02 -0700	[thread overview]
Message-ID: <b72983e6-0560-972a-57c8-9006942ab2a1@linux.vnet.ibm.com> (raw)
In-Reply-To: <c702b775-4a38-bc97-c67f-83f986bbe5fa@redhat.com>

On 11/1/19 12:00 PM, David Hildenbrand wrote:
> 
> No, I don't really like that. Can we please speed up the lookup via a radix tree as noted in the comment of "find_memory_block()".

I agree with the general sentiment that a redesign is the correct long term action - it has been for some time now - but implementing a new storage and retrieval method and verifying that it introduces no new problems itself is non-trivial.  There's a reason it remains a comment.

I don't see any issues with the patch itself.   Do we really want to forego the short term, low-hanging, low risk fruit in favor of waiting indefinitely for that well-tested long-term solution?

Rick

  parent reply	other threads:[~2019-11-01 22:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 18:10 Scott Cheloha
2019-11-01 19:00 ` David Hildenbrand
2019-11-01 19:20   ` David Hildenbrand
2019-11-01 22:32   ` Rick Lindsley [this message]
2019-11-01 22:47     ` David Hildenbrand
2019-11-02 19:43       ` Scott Cheloha
2019-11-02 20:18         ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b72983e6-0560-972a-57c8-9006942ab2a1@linux.vnet.ibm.com \
    --to=ricklind@linux.vnet.ibm.com \
    --cc=cheloha@linux.vnet.ibm.com \
    --cc=david@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathanl@linux.ibm.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®