[PATCH] MIPS: DTS: CI20: fix otg power gpio

[PATCH] MIPS: DTS: CI20: fix otg power gpio

[H. Nikolaus Schaller]

According to schematics it is PF15 and not PF14 (MIC_SW_EN).
Seems as if it was hidden and not noticed during testing since
there is no sound DT node.

Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic SoCs and boards.")
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
index 9819abb2465dd..a276488c0f752 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 
-		gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
+		gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
 		enable-active-high;
 	};
 };
-- 
2.38.1

Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

[Paul Cercueil]

Hi Nikolaus,

Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
écrit :
> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> Seems as if it was hidden and not noticed during testing since
> there is no sound DT node.
> 
> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
> SoCs and boards.")
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Looking at the schematics it looks like you are correct. So:
Acked-by: Paul Cercueil <paul@crapouillou.net>

I'm curious though, it is connected to the "SYS_POWER_IND" trace in the
schematic, which seems to also switch the main led between red and
blue, is that the case?

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 9819abb2465dd..a276488c0f752 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>                 regulator-min-microvolt = <5000000>;
>                 regulator-max-microvolt = <5000000>;
>  
> -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>                 enable-active-high;
>         };
>  };

Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

[H. Nikolaus Schaller]

Hi Paul,

> Am 29.01.2023 um 19:08 schrieb Paul Cercueil <paul@crapouillou.net>:
> 
> Hi Nikolaus,
> 
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
>> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
>> Seems as if it was hidden and not noticed during testing since
>> there is no sound DT node.
>> 
>> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
>> SoCs and boards.")
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> 
> Looking at the schematics it looks like you are correct. So:
> Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!

> 
> I'm curious though, it is connected to the "SYS_POWER_IND" trace in the
> schematic, which seems to also switch the main led between red and
> blue, is that the case?

Yes, the LED changes between blue and red with this patch.

BR,
Nikolaus

> 
> Cheers,
> -Paul
> 
>> ---
>>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>> b/arch/mips/boot/dts/ingenic/ci20.dts
>> index 9819abb2465dd..a276488c0f752 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>>                 regulator-min-microvolt = <5000000>;
>>                 regulator-max-microvolt = <5000000>;
>>  
>> -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
>> +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>>                 enable-active-high;
>>         };
>>  };
> 

Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

[Paul Cercueil]

Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
écrit :
> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> Seems as if it was hidden and not noticed during testing since
> there is no sound DT node.
> 
> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
> SoCs and boards.")
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

I missed it, but every time you have a Fixes: tag, you also need to add
below:
Cc: stable@vger.kernel.org

unless the bug you fix is in one of the RCs (and not in a released
kernel).

I think you should send a V2 with this tag (and my ACK).

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 9819abb2465dd..a276488c0f752 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>                 regulator-min-microvolt = <5000000>;
>                 regulator-max-microvolt = <5000000>;
>  
> -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>                 enable-active-high;
>         };
>  };

Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

[H. Nikolaus Schaller]

> Am 29.01.2023 um 19:47 schrieb Paul Cercueil <paul@crapouillou.net>:
> 
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
>> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
>> Seems as if it was hidden and not noticed during testing since
>> there is no sound DT node.
>> 
>> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
>> SoCs and boards.")
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> 
> I missed it, but every time you have a Fixes: tag, you also need to add
> below:
> Cc: stable@vger.kernel.org

Ah, yes. I missed this too. Checkpatch could have warned but doesn't...

> unless the bug you fix is in one of the RCs (and not in a released
> kernel).
> 
> I think you should send a V2 with this tag (and my ACK).

Will do asap.

BR and thanks,
Nikolaus

> 
> Cheers,
> -Paul
> 
>> ---
>>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>> b/arch/mips/boot/dts/ingenic/ci20.dts
>> index 9819abb2465dd..a276488c0f752 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>>                 regulator-min-microvolt = <5000000>;
>>                 regulator-max-microvolt = <5000000>;
>>  
>> -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
>> +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>>                 enable-active-high;
>>         };
>>  };
> 

Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

[NeilBrown]

On Mon, 30 Jan 2023, Paul Cercueil wrote:
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
> > According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> > Seems as if it was hidden and not noticed during testing since
> > there is no sound DT node.
> > 
> > Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
> > SoCs and boards.")
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> 
> I missed it, but every time you have a Fixes: tag, you also need to add
> below:
> Cc: stable@vger.kernel.org

I don't think you do any more.  The stable team grabs anything that
looks even vaguely like a fix and applies it.  Having a valid Fixes tag
is enough for the stable team to take interest.

NeilBrown


> 
> unless the bug you fix is in one of the RCs (and not in a released
> kernel).
> 
> I think you should send a V2 with this tag (and my ACK).
> 
> Cheers,
> -Paul
> 
> > ---
> >  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> > b/arch/mips/boot/dts/ingenic/ci20.dts
> > index 9819abb2465dd..a276488c0f752 100644
> > --- a/arch/mips/boot/dts/ingenic/ci20.dts
> > +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> > @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
> >                 regulator-min-microvolt = <5000000>;
> >                 regulator-max-microvolt = <5000000>;
> >  
> > -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> > +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
> >                 enable-active-high;
> >         };
> >  };
> 
>