* [PATCH] ata: ahci_st: Remove an unused field in struct st_ahci_drv_data
@ 2024-04-01 12:44 Christophe JAILLET
2024-04-02 3:29 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-04-01 12:44 UTC (permalink / raw)
To: Patrice Chotard, Damien Le Moal, Niklas Cassel
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
linux-arm-kernel, linux-ide
In "struct st_ahci_drv_data", the 'ahci' field is unused.
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Apparently, it has never be used. It is not a left-over from a refactoring.
Compile tested only.
---
drivers/ata/ahci_st.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
index d4a626f87963..79a8b0aa37bf 100644
--- a/drivers/ata/ahci_st.c
+++ b/drivers/ata/ahci_st.c
@@ -30,7 +30,6 @@
#define ST_AHCI_OOBR_CIMAX_SHIFT 0
struct st_ahci_drv_data {
- struct platform_device *ahci;
struct reset_control *pwr;
struct reset_control *sw_rst;
struct reset_control *pwr_rst;
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: ahci_st: Remove an unused field in struct st_ahci_drv_data
2024-04-01 12:44 [PATCH] ata: ahci_st: Remove an unused field in struct st_ahci_drv_data Christophe JAILLET
@ 2024-04-02 3:29 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2024-04-02 3:29 UTC (permalink / raw)
To: Christophe JAILLET, Patrice Chotard, Niklas Cassel
Cc: linux-kernel, kernel-janitors, linux-arm-kernel, linux-ide
On 4/1/24 21:44, Christophe JAILLET wrote:
> In "struct st_ahci_drv_data", the 'ahci' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to for-6.9-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-02 3:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-01 12:44 [PATCH] ata: ahci_st: Remove an unused field in struct st_ahci_drv_data Christophe JAILLET
2024-04-02 3:29 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®