[PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Comfort Oyewole]

Fix the alignment issue in order to adhere to kernel coding style

Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
---
 drivers/comedi/comedi_fops.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
index c09bbe04be6c..efa6dc6d40a6 100644
--- a/drivers/comedi/comedi_fops.c
+++ b/drivers/comedi/comedi_fops.c
@@ -2648,7 +2648,9 @@ static __poll_t comedi_poll(struct file *file, poll_table *wait)
 }
 
 static unsigned int comedi_buf_copy_to_user(struct comedi_subdevice *s,
-	void __user *dest, unsigned int src_offset, unsigned int n)
+					    void __user *dest,
+					    unsigned int src_offset,
+					    unsigned int n)
 {
 	struct comedi_buf_map *bm = s->async->buf_map;
 	struct comedi_buf_page *buf_page_list = bm->page_list;
-- 
2.53.0

Re: [PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Greg KH]

On Sun, Oct 18, 2026 at 02:10:39PM +0100, Comfort Oyewole wrote:
> Fix the alignment issue in order to adhere to kernel coding style
> 
> Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
> ---
>  drivers/comedi/comedi_fops.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Why was this sent twice?

Re: [PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Comfort Oyewole]

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
To: Comfort Oyewole <coyewole7@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visiongravers.com,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: comedi: comedi_fops: fix alignment to
match open parenthesis
Date: 10/18/2026 02:30:28 PM

On Sun, Oct 18, 2026 at 02:10:39PM +0100, Comfort Oyewole wrote:
> Fix the alignment issue in order to adhere to kernel coding style
> 
> Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
> ---
>  drivers/comedi/comedi_fops.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Why was this sent twice?
I apologize for the duplicate email. I thought my mutt configuration didn't work the first time.

[PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Comfort Oyewole]

Fix the alignment issue in order to adhere to kernel coding style

Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
---
 drivers/comedi/comedi_fops.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
index c09bbe04be6c..efa6dc6d40a6 100644
--- a/drivers/comedi/comedi_fops.c
+++ b/drivers/comedi/comedi_fops.c
@@ -2648,7 +2648,9 @@ static __poll_t comedi_poll(struct file *file, poll_table *wait)
 }
 
 static unsigned int comedi_buf_copy_to_user(struct comedi_subdevice *s,
-	void __user *dest, unsigned int src_offset, unsigned int n)
+					    void __user *dest,
+					    unsigned int src_offset,
+					    unsigned int n)
 {
 	struct comedi_buf_map *bm = s->async->buf_map;
 	struct comedi_buf_page *buf_page_list = bm->page_list;
-- 
2.53.0

Re: [PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Greg KH]

On Sun, Oct 18, 2026 at 02:22:49PM +0100, Comfort Oyewole wrote:
> Fix the alignment issue in order to adhere to kernel coding style
> 
> Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
> ---
>  drivers/comedi/comedi_fops.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

This is not a staging driver, why is staging in the subject line and the
cc list?

thanks,

greg k-h

Re: [PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Comfort Oyewole]

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
To: Comfort Oyewole <coyewole7@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: comedi: comedi_fops: fix alignment to
match open parenthesis
Date: 10/18/2026 02:30:05 PM

On Sun, Oct 18, 2026 at 02:22:49PM +0100, Comfort Oyewole wrote:
> Fix the alignment issue in order to adhere to kernel coding style
> 
> Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
> ---
>  drivers/comedi/comedi_fops.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

This is not a staging driver, why is staging in the subject line and the
cc list?
Sorry, I made a mistake while working on my first patch. I just realised the staging drivers are located under drivers/staging dir.
Is there anything I can do to correct this?

thanks,

greg k-h

Re: [PATCH] staging: comedi: comedi_fops: fix alignment to match open parenthesis

[Julia Lawall]

> On 18 Oct 2026, at 10:18, Comfort Oyewole <coyewole7@gmail.com> wrote:
> 
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> To: Comfort Oyewole <coyewole7@gmail.com>
> Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
> linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
> outreachy@lists.linux.dev
> Subject: Re: [PATCH] staging: comedi: comedi_fops: fix alignment to
> match open parenthesis
> Date: 10/18/2026 02:30:05 PM
> 
>> On Sun, Oct 18, 2026 at 02:22:49PM +0100, Comfort Oyewole wrote:
>> Fix the alignment issue in order to adhere to kernel coding style
>> 
>> Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
>> ---
>> drivers/comedi/comedi_fops.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> This is not a staging driver, why is staging in the subject line and the
> cc list?
> Sorry, I made a mistake while working on my first patch. I just realised the staging drivers are located under drivers/staging dir.
> Is there anything I can do to correct this?

Just work on something else.

Julia

>