From: Alex Elder <elder@ieee.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alex Elder <elder@kernel.org>,
Jack Schofield <schofija@oregonstate.edu>,
Vaibhav Nagare <vnagare@redhat.com>,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH] staging: greybus: drop loopback test files
Date: Thu, 6 Apr 2023 07:12:17 -0500 [thread overview]
Message-ID: <b80921e2-9c77-a0dd-9b70-f2ad805f71ff@ieee.org> (raw)
In-Reply-To: <2023040613-huntsman-goldsmith-4a41@gregkh>
On 4/6/23 3:18 AM, Greg Kroah-Hartman wrote:
> The greybus loopback test tool does not belong burried down in a
> driver-specific directory. If it is needed, it should be somewhere
> else, like in the testing directory. But as the loopback driver is
> probably never going to be merged out of the staging directory, let's
> just delete the test alltogether for now. If it's needed in the future,
> it can be brought back with a revert.
>
> Also, having an Android.mk file in the kernel source tree breaks some
> Android build systems when trying to build from a read-only source tree,
> the report of which prompted this being a good reason to remove it as
> well.
>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Jack Schofield <schofija@oregonstate.edu>
> Cc: Vaibhav Nagare <vnagare@redhat.com>
> Cc: greybus-dev@lists.linaro.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
That's a surprising amount of code. And perhaps there
are better ways of exposing this type of information.
Anyway, no objection here.
Acked-by: Alex Elder <elder@linaro.org>
> ---
> drivers/staging/greybus/tools/.gitignore | 2 -
> drivers/staging/greybus/tools/Android.mk | 10 -
> drivers/staging/greybus/tools/Makefile | 33 -
> drivers/staging/greybus/tools/README.loopback | 198 ----
> drivers/staging/greybus/tools/lbtest | 169 ---
> drivers/staging/greybus/tools/loopback_test.c | 979 ------------------
> 6 files changed, 1391 deletions(-)
> delete mode 100644 drivers/staging/greybus/tools/.gitignore
> delete mode 100644 drivers/staging/greybus/tools/Android.mk
> delete mode 100644 drivers/staging/greybus/tools/Makefile
> delete mode 100644 drivers/staging/greybus/tools/README.loopback
> delete mode 100755 drivers/staging/greybus/tools/lbtest
> delete mode 100644 drivers/staging/greybus/tools/loopback_test.c
>
prev parent reply other threads:[~2023-04-06 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 8:18 Greg Kroah-Hartman
2023-04-06 12:12 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b80921e2-9c77-a0dd-9b70-f2ad805f71ff@ieee.org \
--to=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=schofija@oregonstate.edu \
--cc=vnagare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®