[PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

[PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

[Kathiravan Thirumoorthy]

Based on the recent discussion in the linux-arm-msm list[1], it is not
appropriate to define the IMEM (On-Chip SRAM) as syscon or MFD. Since
there are no consumers of this compatible, drop it and move to
mmio-sram.

While at it, add a comment to not to extend the list and move towards
mmio-sram.

[1] https://lore.kernel.org/linux-arm-msm/e4c5ecc3-fd97-4b13-a057-bb1a3b7f9207@kernel.org/

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sram/qcom,imem.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index 6a627c57ae2fecdbb81cae710f6fb5e48156b1f5..3147f3634a531514a670e714f3878e5375db7285 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -14,11 +14,10 @@ description:
   transactions.
 
 properties:
-  compatible:
+  compatible: # Don't grow this list. Please use mmio-sram if possible
     items:
       - enum:
           - qcom,apq8064-imem
-          - qcom,ipq5424-imem
           - qcom,msm8226-imem
           - qcom,msm8974-imem
           - qcom,msm8976-imem

---
base-commit: 52ba76324a9d7c39830c850999210a36ef023cde
change-id: 20250917-ipq5424-imem-350825add3e1

Best regards,
-- 
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

Re: [PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

[Krzysztof Kozlowski]

On Wed, Oct 15, 2025 at 11:46:58AM +0530, Kathiravan Thirumoorthy wrote:
> Based on the recent discussion in the linux-arm-msm list[1], it is not
> appropriate to define the IMEM (On-Chip SRAM) as syscon or MFD. Since
> there are no consumers of this compatible, drop it and move to
> mmio-sram.
> 
> While at it, add a comment to not to extend the list and move towards
> mmio-sram.
> 
> [1] https://lore.kernel.org/linux-arm-msm/e4c5ecc3-fd97-4b13-a057-bb1a3b7f9207@kernel.org/
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> index 6a627c57ae2fecdbb81cae710f6fb5e48156b1f5..3147f3634a531514a670e714f3878e5375db7285 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> @@ -14,11 +14,10 @@ description:
>    transactions.
>  
>  properties:
> -  compatible:
> +  compatible: # Don't grow this list. Please use mmio-sram if possible
>      items:
>        - enum:
>            - qcom,apq8064-imem
> -          - qcom,ipq5424-imem

And where is qcom,ipq5424-imem added? This is supposed to be one patch.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

[Kathiravan Thirumoorthy]

On 10/21/2025 12:32 PM, Krzysztof Kozlowski wrote:
> On Wed, Oct 15, 2025 at 11:46:58AM +0530, Kathiravan Thirumoorthy wrote:
>> Based on the recent discussion in the linux-arm-msm list[1], it is not
>> appropriate to define the IMEM (On-Chip SRAM) as syscon or MFD. Since
>> there are no consumers of this compatible, drop it and move to
>> mmio-sram.
>>
>> While at it, add a comment to not to extend the list and move towards
>> mmio-sram.
>>
>> [1] https://lore.kernel.org/linux-arm-msm/e4c5ecc3-fd97-4b13-a057-bb1a3b7f9207@kernel.org/
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/sram/qcom,imem.yaml | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> index 6a627c57ae2fecdbb81cae710f6fb5e48156b1f5..3147f3634a531514a670e714f3878e5375db7285 100644
>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> @@ -14,11 +14,10 @@ description:
>>     transactions.
>>   
>>   properties:
>> -  compatible:
>> +  compatible: # Don't grow this list. Please use mmio-sram if possible
>>       items:
>>         - enum:
>>             - qcom,apq8064-imem
>> -          - qcom,ipq5424-imem
> And where is qcom,ipq5424-imem added? This is supposed to be one patch.


Kindly excuse for the delay in the response as I was out of work.

This is supposed to be added in the sram.yaml binding, but I haven't 
completed that yet. Between Konrad has done some rework [1] on removing 
the imem.yaml and combined with sram.yaml (in his dev tree). So I hope 
it will be taken care along with that.

Konrad, Can you help to share the plan on when the patches will be 
posted for review? It will be helpful for reviving my other series[2] 
and obviously yours too :)

[1] https://github.com/quic-kdybcio/linux/commits/topic/imem_sram/

[2] 
https://lore.kernel.org/linux-arm-msm/20250610-wdt_reset_reason-v5-0-2d2835160ab5@oss.qualcomm.com/#t


Thanks,

Kathiravan T.


>
> Best regards,
> Krzysztof
>

Re: [PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

[Konrad Dybcio]

On 10/27/25 5:59 AM, Kathiravan Thirumoorthy wrote:
> 
> On 10/21/2025 12:32 PM, Krzysztof Kozlowski wrote:
>> On Wed, Oct 15, 2025 at 11:46:58AM +0530, Kathiravan Thirumoorthy wrote:
>>> Based on the recent discussion in the linux-arm-msm list[1], it is not
>>> appropriate to define the IMEM (On-Chip SRAM) as syscon or MFD. Since
>>> there are no consumers of this compatible, drop it and move to
>>> mmio-sram.
>>>
>>> While at it, add a comment to not to extend the list and move towards
>>> mmio-sram.
>>>
>>> [1] https://lore.kernel.org/linux-arm-msm/e4c5ecc3-fd97-4b13-a057-bb1a3b7f9207@kernel.org/
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>> ---
>>>   Documentation/devicetree/bindings/sram/qcom,imem.yaml | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>> index 6a627c57ae2fecdbb81cae710f6fb5e48156b1f5..3147f3634a531514a670e714f3878e5375db7285 100644
>>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>> @@ -14,11 +14,10 @@ description:
>>>     transactions.
>>>     properties:
>>> -  compatible:
>>> +  compatible: # Don't grow this list. Please use mmio-sram if possible
>>>       items:
>>>         - enum:
>>>             - qcom,apq8064-imem
>>> -          - qcom,ipq5424-imem
>> And where is qcom,ipq5424-imem added? This is supposed to be one patch.
> 
> 
> Kindly excuse for the delay in the response as I was out of work.
> 
> This is supposed to be added in the sram.yaml binding, but I haven't completed that yet. Between Konrad has done some rework [1] on removing the imem.yaml and combined with sram.yaml (in his dev tree). So I hope it will be taken care along with that.
> 
> Konrad, Can you help to share the plan on when the patches will be posted for review? It will be helpful for reviving my other series[2] and obviously yours too :)
> 
> [1] https://github.com/quic-kdybcio/linux/commits/topic/imem_sram/
> 
> [2] https://lore.kernel.org/linux-arm-msm/20250610-wdt_reset_reason-v5-0-2d2835160ab5@oss.qualcomm.com/#t

Let's get an answer on the Kaanapali thread and go from there

https://lore.kernel.org/linux-arm-msm/176222838026.1146775.13955186005277266199.b4-ty@kernel.org/T/#mb3284a3a0bc3a9cda9cc6c0fb9433e8c2dddea2f

Konrad

Re: [PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

[Kathiravan Thirumoorthy]

On 11/4/2025 6:18 PM, Konrad Dybcio wrote:
> On 10/27/25 5:59 AM, Kathiravan Thirumoorthy wrote:
>> On 10/21/2025 12:32 PM, Krzysztof Kozlowski wrote:
>>> On Wed, Oct 15, 2025 at 11:46:58AM +0530, Kathiravan Thirumoorthy wrote:
>>>> Based on the recent discussion in the linux-arm-msm list[1], it is not
>>>> appropriate to define the IMEM (On-Chip SRAM) as syscon or MFD. Since
>>>> there are no consumers of this compatible, drop it and move to
>>>> mmio-sram.
>>>>
>>>> While at it, add a comment to not to extend the list and move towards
>>>> mmio-sram.
>>>>
>>>> [1] https://lore.kernel.org/linux-arm-msm/e4c5ecc3-fd97-4b13-a057-bb1a3b7f9207@kernel.org/
>>>>
>>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/sram/qcom,imem.yaml | 3 +--
>>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>>> index 6a627c57ae2fecdbb81cae710f6fb5e48156b1f5..3147f3634a531514a670e714f3878e5375db7285 100644
>>>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>>> @@ -14,11 +14,10 @@ description:
>>>>      transactions.
>>>>      properties:
>>>> -  compatible:
>>>> +  compatible: # Don't grow this list. Please use mmio-sram if possible
>>>>        items:
>>>>          - enum:
>>>>              - qcom,apq8064-imem
>>>> -          - qcom,ipq5424-imem
>>> And where is qcom,ipq5424-imem added? This is supposed to be one patch.
>>
>> Kindly excuse for the delay in the response as I was out of work.
>>
>> This is supposed to be added in the sram.yaml binding, but I haven't completed that yet. Between Konrad has done some rework [1] on removing the imem.yaml and combined with sram.yaml (in his dev tree). So I hope it will be taken care along with that.
>>
>> Konrad, Can you help to share the plan on when the patches will be posted for review? It will be helpful for reviving my other series[2] and obviously yours too :)
>>
>> [1] https://github.com/quic-kdybcio/linux/commits/topic/imem_sram/
>>
>> [2] https://lore.kernel.org/linux-arm-msm/20250610-wdt_reset_reason-v5-0-2d2835160ab5@oss.qualcomm.com/#t
> Let's get an answer on the Kaanapali thread and go from there
>
> https://lore.kernel.org/linux-arm-msm/176222838026.1146775.13955186005277266199.b4-ty@kernel.org/T/#mb3284a3a0bc3a9cda9cc6c0fb9433e8c2dddea2f


Yeah, I'm also waiting for the conclusion on the thread.


>
> Konrad